Resolve "Changing the interface language in a builder application resets the element editing panel."
requested to merge 1954-changing-the-interface-language-in-a-builder-application-resets-the-element-editing-panel into develop
What is in this MR
The issue here was that the :key
for the Tab
loop was the label itself which is a translation. When the translation changes, the label changes which means that the key changes and therefore we trigger a re-render of all the labels that have changed. Style
was a label that stayed the same when changing languages therefore the key stayed the same therefore no re-render for Style
.
I suppose the lessons learned here is to never use a translation string as the key
in a v-for
since it can cause situations like these.
How to test this MR
- Create a new page
- Change the language to something else
- Watch how the tabs stay in the same order
Merge Request Checklist
-
changelog.md has been updated if required. -
New/updated Premium/Enterprise features are separated correctly in the premium or enterprise folder -
The latest Chrome and Firefox have been used to test any new frontend features -
Documentation has been updated -
Quality Standards are met -
Performance: tables are still fast with 100k+ rows, 100+ field tables -
The redoc API pages have been updated for any REST API changes -
Our custom API docs are updated for changes to endpoints accessed via api tokens -
The UI/UX has been updated following UI Style Guide
Closes #1954 (closed)
Edited by Alexander Haller