Skip to content

Resolve "Application create modal mistakenly submits on click when job is still running"

The airtable import modal instantly closes the second you click import atm. This is because it's embedded inside another form, and has always had this bug, its just before a hidden validation failing was preventing it from submitting, now with a default name for the application it now submits the form and creates a second database whenever you click. In this MR I completely separate the two forms so one isn't nested inside the other to fix the issue.

How to test

  1. Try to import a database from Airtable on develop.
  2. See that a blank "untitled database" is immediately made + the import modal closes immediately
  3. Checkout this MR
  4. Now you should be able to import from airtable without the modal closing
  5. You should also be able to create modals normally.

Merge Request Checklist

  • changelog.md has been updated if required
  • New/updated Premium features are separated correctly in the premium folder
  • The latest Chrome and Firefox have been used to test any new frontend features
  • Documentation has been updated
  • Quality Standards are met
  • Performance: tables are still fast with 100k+ rows, 100+ field tables
  • The redoc API pages have been updated for any REST API changes
  • Our custom API docs are updated for changes to endpoints accessed via api tokens
  • The UI/UX has been updated following UI Style Guide

Closes #1492 (closed)

Edited by Nigel Gott

Merge request reports