Issue still present on 1.23.2 | Caddyfile seems to be broken with docker-compose.yml on 1.23.0
Describe the problem
On some servers I'm still using the "old" docker-compose.yml
instead of the all-on-one version. To upgrade I stop the containers with docker compose down
, pull the repository with git pull
and restart everything with docker compose pull ; docker compose up -d
.
After the upgrade to 1.23.0 the caddy container never came up again with the error message:
Error: adapting config using caddyfile: server block without any key is global configuration, and if used, it must be first
I noticed that there were changes in the Caddyfile one month ago which lead to the issue:
https://gitlab.com/baserow/baserow/-/blame/develop/Caddyfile?ref_type=heads#L42
https://gitlab.com/baserow/baserow/-/blame/develop/Caddyfile?ref_type=heads#L43
https://gitlab.com/baserow/baserow/-/blame/develop/Caddyfile?ref_type=heads#L44
As the variable BASEROW_CADDY_HTTP_CATCH_ALL
is neither propagated in .env.example
, nor in docker-compose.yml
it will be empty by default and the configuration therefore invalid.
Commenting out the three lines 42-44 are bringing caddy up again. But I also think that line 42 and 46 are substituting each other, aren't they?
Would be great if the devs would check and fix that.
Environment
- Operating System: Debian
- Deployment Type: docker
- Baserow Version: 1.23.0