use our own fork of rocksdb
I know it has already been discussed but since I plan to add more features to erlang-rocksdb like the support of LUA for compactions and some other features like custom envs. Since lua rocksdb is about to be remove from the official sources (still used internally) and that others changes are requiring to be added to the code repository I propose to either uses a submodule or a a subtree to simplify any merging with upstream later. Thoughts?
Here is a quick list of pro/cons of each methods:
submodules
pros:
- easy to add, no pollution of the source with custom tags
cons:
- reguires to init the submodules first.
- will requires to fetch the sources before packaging it to hex or work offline.
note: a rebar3 plugin can be created for it.
subtree
pros:
- source is embedded in the repo
cons:
- harder to maintain
- can pollute easily the source with tags from the upstream repo (the repo from where subtree is originally