Skip to content

Unit tests for barrel_id 'a lexicographic ordering requirement have been concluded. Please see the details in the description;

Hakan Barisik requested to merge hbarisik/barrel:fix/lexicographic_ordering into p2

FIX SCP-100:Lexicographic ordering of id gerenation (base62) is tested for various year combinations.
Test would fail for some past periods. However, as the IDs will be generated for these combinations only, we think it is safe to use barrel_id functions. Lexicographic ordering tests: If the id generation was requested in 1975 there would be an issue. lexicographic ordering between 1970 and 1975 would be broken. Also;

  • Lexicographic ordering of IDs between 1970 and 1974 is NOT fine.
  • Lexicographic ordering of IDs between 1970 and 1984 is NOT fine.
  • Lexicographic ordering of IDs between 1970 and 1985 is fine.
  • Lexicographic ordering of IDs between 1980 and 1984 is fine. These findings motivate us to create year pair combination tests (at least for period covering 2019-2284 ).

Merge request reports