Skip to content

Don't extract subviews for `cor()` or `cov()`

Ryan Curtin requested to merge rcurtin/bandicoot-code:cov_cor_subviews into unstable

Another MR that removes the use of extract_subview. This one needed a little bit of special handling, because cor() and cov() have special behavior when given vectors. That special behavior is now encapsulated in the special_cor_cov_unwrap struct.

In addition, this made it possible to remove separate overloads for mtop_conv_to inputs. special_cor_cov_unwrap will not perform type conversions on the inputs, and those will instead be done implicitly by coot_rt_t::mean() and coot_rt_t::copy_mat().

Tests are added for subview handling for all of op_cor, op_cov, glue_cor, and glue_cov.

Merge request reports