Skip to content

Subview support for `join_rows()` and `join_cols()`

Ryan Curtin requested to merge rcurtin/bandicoot-code:join_rows_cols_subviews into unstable

My hopeful goal is to eliminate the use of the extract_subview struct wherever possible. This MR does that for join_rows() and join_cols() (albeit at the cost of making those function signatures huge, so that they have subview arguments for each matrix).

I didn't do any timing tests, but now, e.g., join_rows(A.submat(1, 2, 3, 4), B.submat(4, 5, 6, 7)) will not actually extract the subviews before joining the rows into the output matrix.

This should be merged after !127 (merged) (and the diff will not make sense until that is merged).

Edited by Ryan Curtin

Merge request reports