Resolve "Menu screens doesn't work when working on a cluster"
What does this MR do
- Add a new
dynamic-screen
attribute in options anddynamic-screen-service
attribute to generate a new dynamic screen - Set
menu-screen
as dynamic screen in terms of reading (avoiding to pre-generate it in sign-in) - IMPACT: Dynamic screens now are generated when loading the screen instead of being pre-generated. ScreenBuilder doesn't need the buildClientAction method and it has been removed. Just put the option in the menu and set it as dynamic-screen:
<option name="test" dynamic-screen="true" dynamic-screen-service="testScreenGenerator"
label="TEST_SCREEN" icon="puzzle-piece"/>
- There is no need for redirection nor random values when loading a dynamic screen, as they are generated on-the-fly
Related issues
Fix #516 (closed)
Your checklist for this pull request
-
Make sure your merge request is to develop or /feature /bugfix branch. Don't request your master! -
Check the commit's or even all commits' message styles matches our requested structure. -
Check the commit's pass the CI pipeline. -
New and existing unit tests pass locally with my changes. -
Commented code, particularly in hard-to-understand areas
Closes #516 (closed)
Edited by Pablo Javier García Mora