Skip to content

Defensive changes against copyright dispute

Andrés Correa Casablanca requested to merge copyright-dispute into master

As a result of sharing part of Avatar CLI's code (specifically the version numbering automation part) into one of my clients' projects, that client claimed ownership over it. Implying that I first developed that code for them, and then copied it into Avatar CLI, which is not true.

BUT, what is true is that, after that, I reused around 50 lines of code (that I wrote myself for that client) to read and normalize some environment variables. Which is stupid given that Avatar CLI's pipelines only needed half of that.

So, here we are, I rewrote that code and some other bits that, although clearly different (because they were written from scratch), they have some resemblance to other code due to the fact that it's me, the same person, who wrote that code, and of course someone does not change the way he thinks from one day to the next one.

Overall, I think that, copyright disputes aside, the changes are positive:

  • We use custom environment variables, improving decoupling from the Gitlab CI's environment.
  • We load less environment variables (that's that "half" I mentioned that we did not use at all)
  • The git hooks are slightly faster
  • I removed error handling code because if something explodes... I can perfectly deal with an ugly stack trace, no need for pretty messages (and it's not like it's gonna explode often, the code is quite simple and stable).

Merge request reports