Skip to content

[#404] Apply ament_auto Macros to localization_common

Description

Notes for Reviewer

For some reason I get a syntax error message on cppcheck.

build/localization_common/Testing/20200510-0332/Test.xml: 7 tests, 0 errors, 1 failure, 0 skipped
- cppcheck
  <<< failure message
    -- run_test.py: invoking following command in '/home/miura/AutowareAuto/src/localization/localization_common':
     - /opt/ros/dashing/bin/ament_cppcheck --xunit-file /home/miura/AutowareAuto/build/localization_common/test_results/localization_common/cppcheck.xunit.xml --include_dirs /home/miura/AutowareAuto/src/localization/localization_common/include
    [test/test_relative_localizer.cpp:50]: (error: syntaxError) syntax error
    [test/test_initialization.cpp:34]: (error: syntaxError) syntax error
    2 errors
    -- run_test.py: return code 1
    -- run_test.py: verify result file '/home/miura/AutowareAuto/build/localization_common/test_results/localization_common/cppcheck.xunit.xml'
  >>>
build/localization_common/test_results/localization_common/cppcheck.xunit.xml: 9 tests, 0 errors, 2 failures, 0 skipped
- localization_common.cppcheck error: syntaxError (test/test_initialization.cpp:34)
  <<< failure message
    syntax error
  >>>
- localization_common.cppcheck error: syntaxError (test/test_relative_localizer.cpp:50)
  <<< failure message
    syntax error
  >>>

The syntax error is weird because the build has gone through.

I've tried a lot of things and noticed that when I delete the namespace (following), the message disappears.

namespace autoware
{
namespace localization
{
namespace localization_common
{

and

}  // namespace localization_common
}  // namespace localization
}  // namespace autoware

However, I don't think that's the right way to fix it.

If you know how to fix it, please let me know. If you don't know, I think it should be listed in the issue and managed separately from #404 (closed).

Checklist

  • success colcon build
  • success colcon test
Edited by MIURA Yasuyuki

Merge request reports