Skip to content

[#404] Apply ament_auto Macros to hungarian_assigner

MIURA Yasuyuki requested to merge kokosabu/AutowareAuto:404-apply-ament_auto-macro-hungarian_assigner into master

Description

Notes for Reviewer

  • When I changed to ament_lint_auto_find_test_dependencies, tests increased and an error occurred.
    • If there is a Co-developed between copyright and license, it seems to be an error.

Checklist

  • success colcon build
  • success colcon test

output of concon test-result --verbose

build/hungarian_assigner/Testing/20200507-0440/Test.xml: 6 tests, 0 errors, 2 failures, 0 skipped
- copyright
  <<< failure message
    -- run_test.py: invoking following command in '/home/miura/AutowareAuto/src/fusion/hungarian_assigner':
     - /opt/ros/dashing/bin/ament_copyright --xunit-file /home/miura/AutowareAuto/build/hungarian_assigner/test_results/hungarian_assigner/copyright.xunit.xml
    include/hungarian_assigner/hungarian_assigner.hpp: copyright=Apex.AI, Inc. (2018), license=<unknown>
    include/hungarian_assigner/visibility_control.hpp: copyright=Apex.AI, Inc. (2018), license=<unknown>
    src/hungarian_assigner.cpp: copyright=Apex.AI, Inc. (2018), license=<unknown>
    test/include/test_hungarian_assigner.hpp: copyright=Apex.AI, Inc. (2018), license=<unknown>
    test/src/test_hungarian_assigner.cpp: copyright=Apex.AI, Inc. (2018), license=<unknown>
    5 errors, checked 5 files
    -- run_test.py: return code 1
    -- run_test.py: verify result file '/home/miura/AutowareAuto/build/hungarian_assigner/test_results/hungarian_assigner/copyright.xunit.xml'
  >>>
- uncrustify
  <<< failure message
    -- run_test.py: invoking following command in '/home/miura/AutowareAuto/src/fusion/hungarian_assigner':
     - /opt/ros/dashing/bin/ament_uncrustify --xunit-file /home/miura/AutowareAuto/build/hungarian_assigner/test_results/hungarian_assigner/uncrustify.xunit.xml
    Code style divergence in file 'test/include/test_hungarian_assigner.hpp':

    --- test/include/test_hungarian_assigner.hpp
    +++ test/include/test_hungarian_assigner.hpp.uncrustify
    @@ -109,4 +109,4 @@
    -    {5,  7, 11, 6, 7},
    -    {8,  5,  5, 6, 5},
    -    {6,  7, 10, 7, 3},
    -    {10, 4,  8, 2, 4}
    +    {5, 7, 11, 6, 7},
    +    {8, 5, 5, 6, 5},
    +    {6, 7, 10, 7, 3},
    +    {10, 4, 8, 2, 4}
    @@ -138 +138 @@
    -    {4,   3,  6,  2,  7},
    +    {4, 3, 6, 2, 7},
    @@ -140,2 +140,2 @@
    -    {4,   3,  2,  1,  5},
    -    {8,   7,  6,  9,  6}
    +    {4, 3, 2, 1, 5},
    +    {8, 7, 6, 9, 6}
    @@ -204,6 +204,6 @@
    -  auto fn = [=, &assign](const uint64_t row) {
    -    for (uint64_t idx = 0U; idx < SZ; ++idx) {
    -      const float32_t val = (idx == row) ? 0.0F : 10.0F;
    -      assign.set_weight(val, row, idx);
    -    }
    -  };
    +  auto fn = [ =, &assign](const uint64_t row) {
    +      for (uint64_t idx = 0U; idx < SZ; ++idx) {
    +        const float32_t val = (idx == row) ? 0.0F : 10.0F;
    +        assign.set_weight(val, row, idx);
    +      }
    +    };

    1 files with code style divergence
    No code style divergence in file 'include/hungarian_assigner/hungarian_assigner.hpp'

    No code style divergence in file 'include/hungarian_assigner/visibility_control.hpp'

    No code style divergence in file 'src/hungarian_assigner.cpp'

    No code style divergence in file 'test/src/test_hungarian_assigner.cpp'

    -- run_test.py: return code 1
    -- run_test.py: verify result file '/home/miura/AutowareAuto/build/hungarian_assigner/test_results/hungarian_assigner/uncrustify.xunit.xml'
  >>>
build/hungarian_assigner/test_results/hungarian_assigner/copyright.xunit.xml: 5 tests, 0 errors, 5 failures, 0 skipped
- hungarian_assigner.copyright include/hungarian_assigner/hungarian_assigner.hpp
  <<< failure message
    copyright=Apex.AI, Inc. (2018), license=<unknown>
  >>>
- hungarian_assigner.copyright include/hungarian_assigner/visibility_control.hpp
  <<< failure message
    copyright=Apex.AI, Inc. (2018), license=<unknown>
  >>>
- hungarian_assigner.copyright src/hungarian_assigner.cpp
  <<< failure message
    copyright=Apex.AI, Inc. (2018), license=<unknown>
  >>>
- hungarian_assigner.copyright test/include/test_hungarian_assigner.hpp
  <<< failure message
    copyright=Apex.AI, Inc. (2018), license=<unknown>
  >>>
- hungarian_assigner.copyright test/src/test_hungarian_assigner.cpp
  <<< failure message
    copyright=Apex.AI, Inc. (2018), license=<unknown>
  >>>
build/hungarian_assigner/test_results/hungarian_assigner/uncrustify.xunit.xml: 5 tests, 0 errors, 1 failure, 0 skipped
- hungarian_assigner.uncrustify test/include/test_hungarian_assigner.hpp
  <<< failure message
    Diff with 32 lines
  >>>
Edited by MIURA Yasuyuki

Merge request reports