Work around missing Application#make_nofitier method in flake8 (!31) · Merge requests · Autoware Foundation / Autoware.Auto / AutowareAuto · GitLab

Esteve Fernandez requested to merge esteve/AutowareAuto:work-around-make_nofitier-error-flake8 into master Feb 28, 2019

Flake8 removed the Application#make_notifier method in https://gitlab.com/pycqa/flake8/merge_requests/274 causing ament_lint to fail (https://github.com/ament/ament_lint/pull/124). This change just pins flake8 to an earlier version until we migrate to ROS2 D or until a new version of ament_lint is released for Crystal and we migrate to it.

See https://gitlab.com/AutowareAuto/AutowareAuto/-/jobs/169211258 for an example of our builds failing because of the removal of Application#make_notifier

Here's a CI build with the patch from this merge request applied https://gitlab.com/AutowareAuto/AutowareAuto/pipelines/49691648

Edited Mar 01, 2019 by Esteve Fernandez