Skip to content

Add Spinnaker SDK bridge

Igor Bogoslavskyi requested to merge (removed):395-add-spinnaker-sdk-bridge into master

Description

This MR implements a wrapper around the Spinnaker SDK. See the included design document for details on the decisions made during the implementation.

For more details, see the issue which will be linked below.

Notes for Reviewer

For now this is a stub implementation after moving over from FlyCapture2 SDK towards Spinnaker SDK, which is the newer one and the one that Pointgrey will support in the future for the future cameras.

However, the design of the SDK itself seems slightly suboptimal for mock testing as the BasePtr<T> class that they use for their smart pointer implementation is not polymorphic and does not allow to easily create a mock of an object it wraps. So the tests are missing and I don't see a way to implement them using Google Mock. We could still test the code by using a fake implementation of the SDK and pointing our code to it instead of the real thing.

Checklist

  • Google Mock tests are added
  • The code is running on CI
  • Documentation was updated

Related issue

#395 (closed)

Edited by Igor Bogoslavskyi

Merge request reports