Skip to content

Improving message formatting of supported functions

Warning: A beginner in the open-source world here.

Implementing and using fmt::Display for SupportedFunctions and its sub-structs. This should allow users to understand the functionality even better.

Comparison:

Old version:

Supported laptop functions:
SupportedFunctions { anime_ctrl: AnimeSupportedFunctions(false), charge_ctrl: ChargeSupportedFunctions { charge_level_set: true }, fan_cpu_ctrl: FanCpuSupportedFunctions { stock_fan_modes: true, min_max_freq: false, fan_curve_set: true }, keyboard_led: LedSupportedFunctions { brightness_set: true, stock_led_modes: [], multizone_led_mode: false, per_key_led_mode: false }, rog_bios_ctrl: RogBiosSupportedFunctions { post_sound_toggle: true, dedicated_gfx_toggle: false } }

New version:

Supported laptop functions:

AniMe Matrix:
	Anime Matrix control: false

Charge:
	Battery charge limit control: true

Fan:
	Stock fan modes: true
	Min/max frequency: false
	Fan curve control: true

LED:
	Brightness control: true
	Stock LED modes: []
	Multizone LED mode: false
	Per key LED mode: false

ROG BIOS:
	POST sound toggle: true
	Dedicated GFX toggle: false

Noticed the message to discuss changes with an email or issue before creating the pull request only after implementing the changes. Would be happy to discuss the change here. https://gitlab.com/asus-linux/asusctl/-/blob/main/CONTRIBUTING.md

The pipeline has failed, but the only message I saw there was that my account had to be approved yet, but after doing that, didn't find a way to retry the pipeline checks. For testing have built the package locally and checked the affected functionality.

Sorry if this pull request does not match the requirements, this is my first one 😄

Merge request reports