Refactor force_consistent in optimizers
Checklist
-
I have read the contribution guidelines. -
Unit tests have been added for any new or changed code, and the test suite passes. Note: Your request will likely not be merged without the appropriate tests. -
New features and API Changes are described in doc/releasenotes.rst
. -
"closes #XXXX" is in the body of the MR description to link the related issue, if applicable.
Add a temporary helper to OptimizableAtoms to check whether it should use force_consistent
.
Remove all the highly redundant handling of this variable from the many optimizers and deprecate the parameter as an input to optimizers.
This may slightly affect the results of optimizations since the boolean may be chosen differently depending on calculator or optimizer.
Edited by Ask Hjorth Larsen