BUG: Make Optimizer subclasses respect steps=0

When steps=0, the conditional expression would evaluate to false causing the optimizer to not respect the step condition and run the optimization to completion. This fix solves that bug.

Closes: #1183 (closed), #1258 (closed)

added 80 commits

• c3d6afe7...7f4d1f09 - 79 commits from branch ase:master
• 539f4b08 - Merge branch 'master' into fix-1258

Compare with previous version

mentioned in issue #1258 (closed)

changed the description

mentioned in merge request !2923

changed the description

@askhl --- looks like another issue where pipeline minutes expired, by the way.

Ohhh, thanks! I think I'll deactivate CI/CD for now and reactivate it as needed then. @askhl Will doing so impede this from being merged?

mentioned in merge request !2921 (closed)

Pretty simple fix (single line change). All tests pass locally.

added 1 commit

• 9758a9bf - BUG: Make Optimizer subclasses respect steps=0

Compare with previous version

changed the description

mentioned in merge request !2688 (closed)

Also closes #1183 (closed)

changed the description

@ugognw --- Could you also take care of irun? See !2688 (closed) for context. @askhl requested this in a prior MR that never got merged.

Great find! I've updated the MR accordingly.

added 44 commits

• 9758a9bf...8bf111c0 - 43 commits from branch ase:master
• 5a8bdce5 - BUG: Make Optimizer subclasses respect steps=0

Compare with previous version

Added fix to address same issue in irun as requested in !2688 (closed).

Thank you very much @ugognw, and also to @argon214.

merged

mentioned in commit 5d52acfe