Skip to content

Draft: BUG: Revert model refresh change

ilia-nikiforov-umn requested to merge ilia-nikiforov-umn/ase:revert-kim-model-refresh into master

Reverted previous change (50ca1287) intended to reduce unnecessary model refreshes, as they cause incorrect energies and forces for at least some KIM MEAM Portable Models (see issue #1187 (closed))

@dskarls @yafshar @mjwen, please take a look at this if possible. This change fixes the linked issue, but I don't understand the ASE KIM calculator well enough to understand why the original commit broke things. The original issue is very strange. I will also update the original issue page with a streamlined script for reproducing, one that includes only the problematic models I've found.

Merge request reports