NEB: run faster by fix calc order to get_forces --> get_potential_energy

This PR makes NEB algorithm run faster for some ASE Calculators.

Some ASE Calculator, calculating forces need extra cost and it is skipped when get_potential_energy is called. While potential energy can be calculated intermediately when force is requested.

Before this PR, get_potential_energy is called before get_forces. In this case calculator calculates only potential energy but not forces, followed by re-calculating potential energy and forces.

After this PR, get_forces is invoked at first which results to calculate potential energy as well and thus we can skip the cost of re-calculating get_potential_energy.

changed title from NEB: fix calc order. get_forces --> get_potential_energy to NEB: run faster by fix calc order to get_forces --> get_potential_energy

added 1 commit

• 66dda0b6 - commit

Compare with previous version

added 1 commit

• 8f1fe30d - commit

Compare with previous version

Indeed, I remember making a similar change for cell optimizations. Thank you @corochann.

mentioned in commit f7a10383

merged