Skip to content

Draft: Replace reference state dictionaries with richer Mapping objects

Ask Hjorth Larsen requested to merge refstates-mapping into master

With this change, ase.data.reference_states will be a list of ReferenceState objects.

The plan is to alleviate ase.build.bulk() of some of its, uh, bulk, and to make it easier to create and work with reference states.

The ReferenceState objects are immutable Mappings (and hence mostly API compatible with dictionaries), which incidentally revealed one bug where reference states could be modified by code.

Add tests of the various subtypes of ReferenceState.

Bulk reference data will include the spacegroups from !2222 and should also solve #838.

We should add magmoms as per #467 (closed).

Also it would be nice to solve #458.

Merge request reports