v9 compatibility

Summary

Testing manifest URL: https://gitlab.com/asacolips-projects/foundry-mods/pbta/-/raw/v9compat/system.json

To follow along with v9 compatibility testing, head to the Foundry discord and go to the PBTA - v9 Testing! thread in the #powered-by-the-apocalypse channel.

Identified Issues

Calls to game.data.version

Deprecation warning from actor-sheet.js, game.data.version should be game.version

  if (isOwner) {
      /* Item Dragging */
      // Core handlers from foundry.js
      var handler;
      if (!isNewerVersion(game.data.version, "0.7")) {
        handler = ev => this._onDragItemStart(ev);
      }
  }

rolls.js leading to async warnings

Need to set {async: true} in evaluate() calls.

    // Handle dice rolls.
    if (!PbtaUtility.isEmpty(roll)) {
      // Test if the roll is a formula.
      let validRoll = false;
      try {
        validRoll = await new Roll(roll.trim(), rollData).evaluate();
      } catch (error) {
        validRoll = false;
      }
    }

Call to console.log()

• _pbtaDirectoryTemplates()

Playbooks for autocomplete not loading

Playbooks defined in compendiums aren't loading for autocomplete in the playbook field

Custom Roll Formula on moves not working

Custom Roll Formula on Moves throw errors when trying to roll

rollMoveExecute() in rolls.js:498

May also be related to #55 (closed) and !10 (closed)

Ask prompt not wide enough

See also #51 (closed)

Labels (do-not-change)

/cc @Asacolips