Skip to content

GitLab

Merged
Opened by Rick van Rein@vanreinOwner

Deprecate picohttpparser diameter tests

This was tagged as historic-picohttpparser-tests just before removing historic test programs.

The changes are mostly based on picohttpparser.c/.h and its removal as a backbone protocol for SASL, which is insecure.

  • src/diasasl_cli.c is a dual-mode local extension for freeDiameter; it serves both Diameter and HTTP protocols. The HTTP parts will be removed after this tag, but Diameter service is upheld.
  • test/test-cyrus.c is older code and has already migrated to the apachemod project. It is a HTTP-SASL client based on Cyrus-SASL2. It will be removed after this tag.
  • test/test-diameter.c is a misnomer; it has no relation to Diameter. It is a HTTP-SASL client based on XoverSASL. It will be removed after this tag.
  • src/picohttpparser.[ch] are the wonderfully modest HTTP libraries, and they will be removed after this tag.
  • PCRE is no longer used in src/diasasl_cli.c after removal of HTTP, and nor does any other module use it; it will be removed as a dependency but kept as an include for CMake.
  • snoprintf() is no longer used but is generally useful and will be kept.
  • {src,test}/CMakeLists.txt will be updated to accommodate the changes above.