Skip to content
Snippets Groups Projects
André Offringa's avatar
commented on merge request !255 "Use system version of pybind11" at André Offringa / AOFlagger

Yup! PS, we already gave up Ubuntu 18 support ;). We're using c++20 now, which requires Ubuntu20.

André Offringa's avatar
deleted branch use-system-pybind11 at André Offringa / AOFlagger
André Offringa's avatar
pushed to branch master at André Offringa / AOFlagger
  • 7d83ebea · Use system version of pybind11
André Offringa's avatar
accepted merge request !255 "Use system version of pybind11" at André Offringa / AOFlagger
Timo Millenaar's avatar
approved merge request !255 "Use system version of pybind11" at André Offringa / AOFlagger
Timo Millenaar's avatar
commented on merge request !255 "Use system version of pybind11" at André Offringa / AOFlagger

Ah okay, so I guess with this change then we give up support for Ubuntu 18. But hey, I imagine we'd rather have it work with CMake 4.0 than Ubuntu ...

André Offringa's avatar
commented on merge request !255 "Use system version of pybind11" at André Offringa / AOFlagger

Ok so the git log / changelogs actually tell why, it was to solve this issue on Ubuntu 18: #25 (closed)

André Offringa's avatar
commented on merge request !255 "Use system version of pybind11" at André Offringa / AOFlagger

I'm not entirely sure why we did it for aoflagger, but I think that the pybind11 version of older Ubuntu's (really talking about 2016 or 2018 and e...

Timo Millenaar's avatar
commented on merge request !255 "Use system version of pybind11" at André Offringa / AOFlagger

While this MR makes sense to me, why was the dependency a submodule before? Did you want to pin a version or force a build from source?

Timo Millenaar's avatar
André Offringa's avatar
opened merge request !255 "Use system version of pybind11" at André Offringa / AOFlagger
André Offringa's avatar
pushed new branch use-system-pybind11 at André Offringa / AOFlagger
André Offringa's avatar
deleted branch fix-drawing-large-images at André Offringa / AOFlagger
André Offringa's avatar
pushed to branch master at André Offringa / AOFlagger
  • 96be534c · Fix drawing of >32K timestep data sets
André Offringa's avatar
accepted merge request !254 "Fix drawing of >32K timestep data sets" at André Offringa / AOFlagger
André Offringa's avatar
pushed to branch fix-drawing-large-images at André Offringa / AOFlagger
André Offringa's avatar
deleted branch allow-writing-to-filterbanksets at André Offringa / AOFlagger
André Offringa's avatar
pushed to branch master at André Offringa / AOFlagger
  • b5509fcc · Fix writing to Filterbank sets
André Offringa's avatar
accepted merge request !253 "Fix writing to Filterbank sets" at André Offringa / AOFlagger
André Offringa's avatar
pushed to branch allow-writing-to-filterbanksets at André Offringa / AOFlagger