bark: Fix short client timeout issue

Steven Rooserequested to merge
client-timeout into master
  • check or remove this line after you've added a CHANGELOG entry or if your PR doesn't need one (they should go into CHANGELOG/unreleased/)

We had our bark global gRPC timeout set to 10 minutes.

Solving this is non-trivial mainly because we want a relatively short timeout for all our normal requests (10 mins, could actually be shorter?). But this timeout also applies to the streams, meaning that streams get cut off at this time as well. Also, if you set a global timeout and a request specific timeout, the smallest will be picked (i.e. you can't increase from the default timeout at request time).

This PR:

  • unsets the global timeout
  • changes the interceptor to add a request-specific timeout of 10 mins if no timeout was already set on the request
  • set a 1 hr timeout for the two subscribe calls we have in bark

This mainly fixes the general way we set timeouts, I'm definitely open to bike-shedding the specific values used.

Edited by Steven Roose

Merge request reports