Skip to content
Snippets Groups Projects

fix af_unix tests for v8 networking.

Merged John Johansen requested to merge jjohansen/apparmor:fix-af_unix-tests into master
1 unresolved thread

The unix network tests are not being run on a v8 network capable kernel. Under v8 there needs to be some adjustments to the tests because unix rules get downgraded to the socket rule network unix, which does not have the same set of conditionals or fine grained permissions, meaning some tests that would fail under af_unix (like missing permission tests) will pass under v8 network rules.

Signed-off-by: John Johansen john.johansen@canonical.com

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Georgia Garcia
  • John Johansen added 263 commits

    added 263 commits

    • b5e048d3...cf6539b2 - 261 commits from branch apparmor:master
    • f47d5c70 - fix af_unix tests for v8 networking.
    • 1fc38dbd - regression tests: switch from bashism == to posix str comparison =

    Compare with previous version

  • John Johansen resolved all threads

    resolved all threads

  • also added a patch to convert all the == bashisms to =

  • Georgia Garcia
    Georgia Garcia @georgiag started a thread on commit f47d5c70
  • 65 65 badperm=wl
    66 66 af_unix=""
    67 67
    68 if [ "$(kernel_features network/af_unix)" == "true" -a "$(parser_supports 'unix,')" == "true" ]; then
    68 if [ "$(kernel_features network_v8)" = "true" -a "$(parser_supports 'unix,')" = "true" ]; then
    • nitpick: I think it would look better if they all had the same condition format, and I think the one used unix_socket_pathname.sh looks nicer

      if ( [ "$(kernel_features network_v8/af_unix)" = "true" ] ||
           [ "$(kernel_features network/af_unix)" = "true" ] ) &&
           [ "$(parser_supports 'unix,')" = "true" ] ; then
    • Please register or sign in to reply
  • Georgia Garcia approved this merge request

    approved this merge request

  • John Johansen mentioned in commit 59b4109a

    mentioned in commit 59b4109a

  • merged

  • John Johansen mentioned in commit ba1aba4c

    mentioned in commit ba1aba4c

  • John Johansen mentioned in commit 7bd1c4d8

    mentioned in commit 7bd1c4d8

  • John Johansen mentioned in commit 6da000f4

    mentioned in commit 6da000f4

  • backported to 3.1, 3.0, 2.13

  • Please register or sign in to reply
    Loading