Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
  • apparmor apparmor
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 117
    • Issues 117
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 26
    • Merge requests 26
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • AppArmorAppArmor
  • apparmorapparmor
  • Merge requests
  • !713

libapparmor: Adjust stacking interface check

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged John Johansen requested to merge jjohansen/apparmor:fix-attr-check into master Feb 16, 2021
  • Overview 18
  • Commits 8
  • Pipelines 9
  • Changes 4

TODO: tests

libapparmor performs a test for the new stacking interface, however how it does this test is problematic as it requires all confined tasks to be given read access to the task introspection interface.

This results in tasks needing to be given read access to the interface even if they don't need it. Making it possible for tasks to discover their confinement even if they are not supposed to be able to.

Instead change the check to using state on the parent directory. This will generate a getattr request instead of read and make it on the directory instead of on any interface file that could be used to obtain information.

Signed-off-by: John Johansen john.johansen@canonical.com

Edited Jul 21, 2021 by John Johansen
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix-attr-check