resolves #522 upgrade asciidoctor

This might provide a starting point for #522 (closed). After the obvious upgrades to use asciidoctor in its new location, and some method name changes, several tests fail.

Most of these are due to apparently changed include level tracking in asciidoctor. Fortunately there's a useful method to find out if the max depth is exceeded. The relative level doesn't seem to be the same however. I also don't understand why we wouldn't always report an error when the max depth is exceeded, nor how the condition for reporting could fail to hold.

At this point 5 tests in load-asciidoc-test.js fail:

• Missing block handlers no longer cause a warning. I suspect there's an info message logged, but we can't see it; adding logging should help.
• The output for two include nesting tests has changed; I don't know that we'd need to replicate the old output.
• Two footnote tests produce invalid html with the previous input, which looks exceedingly peculiar to me. Removing the escape on the final ']' makes the tests pass.

I've commented the significant change in the include processor and the test changes.

added 49 commits

• 7ddcbaad...b2842ba9 - 46 commits from branch antora:master
• cd0a9c1b - upgrade to asciidoctor 2.0.3: tests run with failures
• f4fde656 - code fixes for asciidoctor changes
• 1a3593ec - test changes for changed asciidoctor behavior or questionable test content

Compare with previous version

mentioned in merge request !440

added 178 commits

• 1a3593ec...7c27f858 - 175 commits from branch antora:master
• d70e9349 - upgrade to asciidoctor 2.0.3: tests run with failures
• 068ee483 - code fixes for asciidoctor changes
• ed3b8a98 - test changes for changed asciidoctor behavior or questionable test content

Compare with previous version

Two footnote tests produce invalid html with the previous input

Yes, I added these tests because I knew this was changing. As these are negative tests, they won't be needed any longer (or need to be rewritten to assert something different). It's a reminder to document this change in parsing behavior.

added 247 commits

• ed3b8a98...9f2752ba - 244 commits from branch antora:master
• e51a8c3c - upgrade to asciidoctor 2.0.3: tests run with failures
• 27ebcf37 - code fixes for asciidoctor changes
• a571c1c5 - test changes for changed asciidoctor behavior or questionable test content

Compare with previous version

The MR is now using asciidoctor 2.1.1.

added 31 commits

• a571c1c5...880da18f - 28 commits from branch antora:master
• 724c17f6 - upgrade to asciidoctor 2.2.0: tests run with failures
• 7caf8ead - code fixes for asciidoctor changes
• 37ab10ef - test changes for changed asciidoctor behavior or questionable test content

Compare with previous version

added 21 commits

• 37ab10ef...b5c90bd5 - 18 commits from branch antora:master
• d81f39f9 - upgrade to asciidoctor 2.2.0: tests run with failures
• bca9ad8f - code fixes for asciidoctor changes
• 08ac08c9 - test changes for changed asciidoctor behavior or questionable test content

Compare with previous version

@djencks thank you for this. How do you estimate next steps?

The main blocker is that the Asciidoctor upgrade breaks the docs.antora.org site. That has to be resolved in order for us to move on this. And I cannot look at that problem until I finish the rollout of the docs.asciidoctor.org site, which I'm currently working on daily. I want to get Antora 3.0 wrapped up as soon as possible, but as soon as possible might still be several weeks away.

Closing in favor of !621 (merged).

closed