Skip to content

`pre-commit` Update and File Permission Fixes

Peter Pfeufer requested to merge ppfeufer/allianceauth:pre-commit-update into master

This MR does:

pre-commit checks have been structured better and hook versions updated.

Update our pre-commit config with some added checks for:

  • Git merge conflicts
  • Too large files (max. 1000kb)
  • Possible user or other credentials in files
  • Valid syntax in non-Python files (.yaml, .toml)
  • Leftover debug statements
  • Executable files that are not supposed to be executable
  • Django Upgrade checks to keep our Django code up to date and remove/replace deprecations

Fixing the following

  • Use of deprecated Django code
  • Executable files that are not supposed to be executable:
    • allianceauth/srp/tests/test_managers.py marked executable but has no (or invalid) shebang!
    • allianceauth/services/modules/teamspeak3/util/ts3.py marked executable but has no (or invalid) shebang!
    • allianceauth/services/modules/openfire/manager.py marked executable but has no (or invalid) shebang!
    • allianceauth/hrapplications/views.py marked executable but has no (or invalid) shebang!
    • .tx/config_20230406134150.bak marked executable but has no (or invalid) shebang!
    • allianceauth/srp/views.py marked executable but has no (or invalid) shebang!
    • allianceauth/authentication/models.py marked executable but has no (or invalid) shebang!
    • allianceauth/timerboard/__init__.py marked executable but has no (or invalid) shebang!
    • allianceauth/services/views.py marked executable but has no (or invalid) shebang!
    • allianceauth/timerboard/admin.py marked executable but has no (or invalid) shebang!
    • allianceauth/srp/__init__.py marked executable but has no (or invalid) shebang!
    • allianceauth/services/modules/teamspeak3/manager.py marked executable but has no (or invalid) shebang!
    • README.md marked executable but has no (or invalid) shebang!
    • allianceauth/groupmanagement/views.py marked executable but has no (or invalid) shebang!
    • allianceauth/services/modules/openfire/templates/services/openfire/broadcast.html marked executable but has no (or invalid) shebang!
    • allianceauth/hrapplications/models.py marked executable but has no (or invalid) shebang!
    • allianceauth/srp/tests/__init__.py marked executable but has no (or invalid) shebang!
    • allianceauth/hrapplications/admin.py marked executable but has no (or invalid) shebang!
    • allianceauth/srp/models.py marked executable but has no (or invalid) shebang!
    • allianceauth/srp/form.py marked executable but has no (or invalid) shebang!
    • allianceauth/authentication/managers.py marked executable but has no (or invalid) shebang!
    • allianceauth/timerboard/models.py marked executable but has no (or invalid) shebang!
    • allianceauth/eveonline/views.py marked executable but has no (or invalid) shebang!
    • allianceauth/services/templates/services/services.html marked executable but has no (or invalid) shebang!
    • allianceauth/hrapplications/forms.py marked executable but has no (or invalid) shebang!
    • allianceauth/services/modules/teamspeak3/util/__init__.py marked executable but has no (or invalid) shebang!
    • allianceauth/timerboard/form.py marked executable but has no (or invalid) shebang!
    • allianceauth/urls.py marked executable but has no (or invalid) shebang!
    • allianceauth/services/modules/discord/tests/piloting_tasks.py marked executable but has no (or invalid) shebang!
    • allianceauth/srp/admin.py marked executable but has no (or invalid) shebang!
    • allianceauth/services/modules/phpbb3/manager.py marked executable but has no (or invalid) shebang!
    • allianceauth/timerboard/views.py marked executable but has no (or invalid) shebang!
Edited by Peter Pfeufer

Merge request reports