Skip to content

Resolve "Run mypy with check_untyped_defs"

Vetle Simensen requested to merge 2263-run-mypy-with-check_untyped_defs into epic-autumn-cleaning

Description

This MR enables the flag check_untyped_defs so that mypy also type checks untyped functions/methods. Additional mypy checks have also been enabled and all resulting issues have been fixed. Moreover, the use of the legacy functions bulk_update_mappings and bulk_insert_mappings have been replaced with basic insert calls as per SQLAlchemy 2.0.

Notes to review (code/docs/QA)

  • src/datalayer/tests/test_externalfilter.py Parts of conditionals in the original implementation were never reached. Code now simplified to better represent the actual behavior.

Related issues

Closes #2263 (closed)

Edited by Øyvind Evju

Merge request reports