Skip to content

Resolve "API returns invalid IGV config"

Tor Solli-Nowlan requested to merge 2158-pydantic-returns-invalid-igv-config into dev

Description

Casing on the the keys for the data structure passed to igv.js changed unexpectedly. This was due to using the name attribute of the enum for the dict key rather than the enum itself. Updated the code to use the enums directly and standardized the remaining enums to also use all uppercase in their names.

The malformed data structure was causing igv.js to repeatedly crash even when the visual tab was not selected. This caused significant CPU drain, which is believed to be the source of the recent increase in flakiness of the e2e tests.

Scope creep

  • Moved the fix for the recent git vulnerability to the Dockerfile rather than being mounted externally just for e2e testing. This is a better fix in general and the issue was causing problems for review apps and likely for the ella-frontend compose stack as well.

Related issues

Closes #2158 (closed), #2157 (closed), Related to ella-frontend#179 (closed)

Notes to review (code/docs/QA)

Tests

General

  • Tests have been added that prove my fix is effective or that my feature works
  • Related tests have been modified/removed

Hypothesis testing:

  • Soak testing has been done
  • Distribution between positive / negative cases has been checked

Database

  • Includes changes to database schema
  • Includes necessary database migrations

Configuration

  • Includes changes to configuration
  • Includes configuration migration instructions in documentation
Edited by Tor Solli-Nowlan

Merge request reports