Skip to content

Resolve "add type hints to api.v1.resources.workflow.allele.AlleleInterpretationAllelesListResource"

Tor Solli-Nowlan requested to merge 2008-add-type-hints-to-api-v1-resources-workflow-allele-alleleinterpretationalleleslistresource into 1986-add-typing-to-all-of-our-api-endpoints

Description

  • adds AlleleListResource pydantic model to validate workflow.allele.AlleleInterpretationAllelesListResource
  • adds type hints to all workflow.helpers functions
  • refactors allele/analysis interpretation functions to use a dataclass rather than a bunch of different functions

Related issues

Notes to review (code/docs/QA)

Tests

General

  • Tests have been added that prove my fix is effective or that my feature works
  • Related tests have been modified/removed

Hypothesis testing:

  • Soak testing has been done
  • Distribution between positive / negative cases has been checked

Database

  • Includes changes to database schema
  • Includes necessary database migrations

Configuration

  • Includes changes to configuration
  • Includes configuration migration instructions in documentation

Closes #2008 (closed)

Edited by Tor Solli-Nowlan

Merge request reports