Skip to content

[56-fix-allele-length] length && open_end_position

Tom requested to merge 56-fix-allele-length-calculation into 56-cnv-main

Description

I lost all the changes you did in the source code, don't know how that happened. I hope I was able to resolve everything from memory.

Related issues

Notes to review (code/docs/QA)

In the test for SNV I need to subtract 1 from DEL when calculating the length. Should investigate the reason for this.

Tests

General

  • Tests have been added that prove my fix is effective or that my feature works
  • Related tests have been modified/removed

Hypothesis testing:

  • Soak testing has been done
  • Distribution between positive / negative cases has been checked

Database

  • Includes changes to database schema
  • Includes necessary database migrations

Configuration

  • Includes changes to configuration
  • Includes configuration migration instructions in documentation

Merge checklist

  • Self-review of code has been performed.
  • Feature review and validation against specification has been performed (if applicable). Apply label: QAdone
  • Need for documentation has been evaluated and, if necessary, updated. Apply label: docsdone
  • Code and implementation has been reviewed by other core developer (including any changes based on initial review). Apply label: code reviewdone

#56 (closed)

Edited by Øyvind Evju

Merge request reports

Loading