Skip to content

Resolve "Add watcher blacklist"

Øyvind Evju requested to merge 196-add-watcher-blacklist into dev

Description

Added --blacklist argument to watcher.

Allow specifying --whitelistfile and --blacklistfile which defaults to environment variables ELLA_WATCHER_WHITELISTFILE and ELLA_WATCHER_BLACKLISTFILE. Changes to these will be registered without needing to restart the watcher. The use of environment variables allow users to use default supervisor config.

If both file and command line argument is provided, command line argument takes precedence.

Related issues

#196 (closed)

Notes to review (code/docs/QA)

Tests

General

  • Tests have been added that prove my fix is effective or that my feature works
  • Related tests have been modified/removed

Hypothesis testing:

  • Soak testing has been done
  • Distribution between positive / negative cases has been checked

Database

  • Includes changes to database schema
  • Includes necessary database migrations

Configuration

  • Includes changes to configuration
  • Includes configuration migration instructions in documentation

Merge checklist

  • Self-review of code has been performed.
  • Feature review and validation against specification has been performed (if applicable). Apply label: QAdone
  • Need for documentation has been evaluated and, if necessary, updated. Apply label: docsdone
  • Code and implementation has been reviewed by other core developer (including any changes based on initial review). Apply label: code reviewdone

Closes #196 (closed)

Edited by Øyvind Evju

Merge request reports