Resolve: "Reduce number of toast errors and logged javascript errors"
Description
Keep a cache of running Cerebral signals, and disable error logging of current running signals when the view is changed. These signals are expected to fail since the state tree is being overwritten by changeView
. In addition, abort all running http requests when changing view to avoid unnecessary loads.
Related issues
Closes #271 (closed)
Notes to review (code/docs/QA)
Tests
General
-
Tests have been added that prove my fix is effective or that my feature works -
Related tests have been modified/removed
Hypothesis testing:
-
Soak testing has been done -
Distribution between positive / negative cases has been checked
Database
-
Includes changes to database schema -
Includes necessary database migrations
Configuration
-
Includes changes to configuration -
Includes configuration migration instructions in documentation
Merge checklist
-
Self-review of code has been performed. -
Feature review and validation against specification has been performed (if applicable). Apply label: QAdone -
Need for documentation has been evaluated and, if necessary, updated. Apply label: docsdone -
Code and implementation has been reviewed by other core developer (including any changes based on initial review). Apply label: code reviewdone
Edited by Øyvind Evju