Skip to content

Resolve "Refactor CustomAnnotationModal to Cerebral"

Øyvind Evju requested to merge refactor-non-cerebral-modals into dev

Description

Split customAnnotationModal into three new Cerebral-type modals: "addPrediction", "addExternal" and "addReferences"

Additionally:

  • Removed now unused code.
  • Moved some logic to backend.

Functionality should be identical, except that the form is now cleared when navigating between modes in Add studies (e.g. search phrase is reset if you select PUBMED or MANUAL).

Related issues

#223 (closed)

Notes to review (code/docs/QA)

QA: Check that the three modals for Add prediction, Add external and Add studies work as before.

Tests

General

  • Tests have been added that prove my fix is effective or that my feature works
  • Related tests have been modified/removed

Hypothesis testing:

  • Soak testing has been done
  • Distribution between positive / negative cases has been checked

Database

  • Includes changes to database schema
  • Includes necessary database migrations

Configuration

  • Includes changes to configuration
  • Includes configuration migration instructions in documentation

Merge checklist

  • Self-review of code has been performed.
  • Feature review and validation against specification has been performed (if applicable). Apply label: QAdone
  • Need for documentation has been evaluated and, if necessary, updated. Apply label: docsdone
  • Code and implementation has been reviewed by other core developer (including any changes based on initial review). Apply label: code reviewdone

Closes #223 (closed)

Edited by Morten C. Eike

Merge request reports