Skip to content

Resolve "Enable filters in ANALYSES overivew"

Tor Solli-Nowlan requested to merge 179-enable-filters-in-analyses-overivew into dev

Description

See #179 (closed)

Adds analyses overview filters for:

  • Sample name (free text)
  • Review comment (free text)
  • Technology: HTS, Sanger (can select multiple to support new technology options in the future)
  • Priority: Normal, High, Urgent (can select multiple)
  • Date requested (or, if missing, submission date): 1 day ago, 3 days ago, 1 week ago, 1 month ago, 3 months ago, more than 3 months ago

Filter navbar only shows up when on the overview/analyses page

Free text filters assume users are not using regular expressions themselves. Treats . as the literal string instead of as wildcard, and treats * as wildcard by substituting with the regular expression .+

Adds e2e tests for all filters and reset filter button

Notes to code review

Made an attempt at CSS that isn't horrible, but very open to any suggestions or guidance

Notes to feature review/validation

Tests

$ SPEC=search_alleles_and_analyses.js make test-e2e

General

  • Tests have been added that prove my fix is effective or that my feature works

Hypothesis testing:

  • Soak testing has been done
  • Distribution between positive / negative cases has been checked

Merge checklist

  • Self-review of code performed
  • Feature review and validation against specification (if applicable)
  • Need for documentation has been evaluated and, if necessary, updated
  • Code and implementation is reviewed by other core developer (all changes, inc. changes based on initial review)

Closes #179 (closed)

Edited by Svein Tore Koksrud Seljebotn

Merge request reports