Fix issue when analysis watcher can't move analysis folder
Description
Closes issues: LA-1531 Related issues:
See issue. DepositAnalysis performed a commit inside, leaving no control to outside code whether things should actually be committed or not.
Notes to reviewer
Please double check that we commit() in all places where import_vcf()
is used.
Type of change
Application (affects UI or general functionality):
-
New feature -
Bug fix -
Improvement
Ops / admin / CI related only (not impacting users):
-
New feature -
Bug fix -
Improvement
Tests
General
-
Tests have been added that prove my fix is effective or that my feature works -
Related tests have been modified/removed
Hypothesis testing:
-
Soak testing has been done -
Distribution between positive / negative cases has been checked
Database
-
Includes changes to database schema -
Includes necessary database migrations
Configuration
-
Includes changes to configuration -
Includes configuration migration instructions in documentation
Merge checklist
-
Self-review of code performed -
Feature review against specification (if applicable) -
Need for documentation has been evaluated and, if necessary, updated -
Code and implementation is reviewed by other core developer (all changes, inc. changes based on initial review)
Edited by Øyvind Evju