Skip to content

Fix e2e tests for new chrome version

Description

Closes issues: Related issues:

After Ubuntu image updating to Chrome/Chromedriver version 78, webdriver command clear element's focus logic changed, breaking updates of contenteditables that had preexisting content.

This MR adds a workaround for the issue by not using setValue(), but splitting up the command and refocusing in-between.

Notes to reviewer

See change in wysiwygEditor.directive.js. Unless we blur(), the component ended up in a wrong state, where placeholder was shown, alongside the button row, but no editor. This shouldn't be possible. I added a call to blur() to make sure everything is updated.

Type of change

Application (affects UI or general functionality):

  • New feature
  • Bug fix
  • Improvement

Ops / admin / CI related only (not impacting users):

  • New feature
  • Bug fix
  • Improvement

Tests

General

  • Tests have been added that prove my fix is effective or that my feature works
  • Related tests have been modified/removed

Hypothesis testing:

  • Soak testing has been done
  • Distribution between positive / negative cases has been checked

Database

  • Includes changes to database schema
  • Includes necessary database migrations

Configuration

  • Includes changes to configuration
  • Includes configuration migration instructions in documentation

Merge checklist

  • Self-review of code performed
  • Feature review against specification (if applicable)
  • Need for documentation has been evaluated and, if necessary, updated
  • Code and implementation is reviewed by other core developer (all changes, inc. changes based on initial review)
Edited by Svein Tore Koksrud Seljebotn

Merge request reports