Skip to content

Fix filter region to correctly treat intervals as half-closed

Øyvind Evju requested to merge 1519-revisit-open-vs-closed-region-intervals into dev

Description

Closes issues: LA-1519 Related issues:

Region filter assumed closed intervals, but the BED-format specifies that intervals are half-closed [start, end). Fix region filter to take this into account.

With this bug, we have risked that +1/-1-variants are filtered out in the region filter. However, they would be rescued on HGVSc distance if annotated correctly.

Notes to reviewer

Type of change

Application (affects UI or general functionality):

  • New feature
  • Bug fix
  • Improvement

Ops / admin / CI related only (not impacting users):

  • New feature
  • Bug fix
  • Improvement

Tests

General

  • Tests have been added that prove my fix is effective or that my feature works
  • Related tests have been modified/removed

Hypothesis testing:

  • Soak testing has been done
  • Distribution between positive / negative cases has been checked

Database

  • Includes changes to database schema
  • Includes necessary database migrations

Configuration

  • Includes changes to configuration
  • Includes configuration migration instructions in documentation

Merge checklist

  • Self-review of code performed
  • Feature review against specification (if applicable)
  • Need for documentation has been evaluated and, if necessary, updated
  • Code and implementation is reviewed by other core developer (all changes, inc. changes based on initial review)
Edited by Svein Tore Koksrud Seljebotn

Merge request reports