Skip to content

Non-ACMG criteria and unweighted ACMG criteria

Øyvind Evju requested to merge 1248-non-acmg-criteria into dev

Description

Closes issues: LA-1248, LA-1321 Related issues:

Allow user to select an "OTHER"-criteria, that can be used for criteria not covered by ACMG guidelines. Also add the possibility to not weigh ACMG-criteria, by selecting the '-'-sign next to the criteria.

Neither the non-ACMG criteria nor the unweghted ACMG-criteria will be used for suggesting class.

Notes to reviewer

Type of change

Application (affects UI or general functionality):

  • New feature
  • Bug fix
  • Improvement

Ops / admin / CI related only (not impacting users):

  • New feature
  • Bug fix
  • Improvement

Tests

General

  • Tests have been added that prove my fix is effective or that my feature works
  • Related tests have been modified/removed

Hypothesis testing:

  • Soak testing has been done
  • Distribution between positive / negative cases has been checked

Database

  • Includes changes to database schema
  • Includes necessary database migrations

Configuration

  • Includes changes to configuration
  • Includes configuration migration instructions in documentation

Merge checklist

  • Self-review of code performed
  • Feature review against specification (if applicable)
  • Need for documentation has been evaluated and, if necessary, updated
  • Code and implementation is reviewed by other core developer (all changes, inc. changes based on initial review)

Closes #1248

Edited by Morten C. Eike

Merge request reports