Skip to content

Fix bug causing selectedAllele === null

Øyvind Evju requested to merge not-relevant-null-allele into dev

Description

Closes issues: LA-1473 Related issues:

When all variants in an analysis is set to not relevant, the prepareSelectedAllele logic set selectedAllele to null. Prevent this by selecting the top notRelevant allele.

This manifested itself by showing a "null"-allele in interpretation view, and the user being able to interact with the controls. When clicking "Mark not relevant" on this "null"-allele, this was added to state with under the key "null".

Notes to reviewer

Type of change

Application (affects UI or general functionality):

  • New feature
  • Bug fix
  • Improvement

Ops / admin / CI related only (not impacting users):

  • New feature
  • Bug fix
  • Improvement

Tests

General

  • Tests have been added that prove my fix is effective or that my feature works
  • Related tests have been modified/removed

Hypothesis testing:

  • Soak testing has been done
  • Distribution between positive / negative cases has been checked

Database

  • Includes changes to database schema
  • Includes necessary database migrations

Configuration

  • Includes changes to configuration
  • Includes configuration migration instructions in documentation

Merge checklist

  • Self-review of code performed
  • Feature review against specification (if applicable)
  • Need for documentation has been evaluated and, if necessary, updated
  • Code and implementation is reviewed by other core developer (all changes, inc. changes based on initial review)
Edited by Morten C. Eike

Merge request reports