Skip to content

[db] Add a refined json schema for filterconfigs

Øyvind Evju requested to merge filterconfig-json-schema into dynamic-filter-config

Description

Closes issues: Related issues:

Tightened up the JSON schema for filterconfigs. It now disallows any other properties than what is defined in the schema, together with restrictions on values where applicable. Tests have been added by letting hypothesis modify the filter config at "random" nodes, and assert that the schema validation fails.

Notes to reviewer

[Are there points in the code the reviewer needs to double check or where you would like advice?]

Type of change

  • New feature
  • Breaking change
  • Bug fix
  • Improvement

Tests

General

  • Tests have been added that prove my fix is effective or that my feature works
  • Related tests have been modified/removed

Hypothesis testing:

  • Soak testing has been done
  • Distribution between positive / negative cases has been checked

Database

  • Includes changes to database schema
  • Includes necessary database migrations

Configuration

  • Includes changes to configuration
  • Includes configuration migration instructions in documentation

General

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My branch has recently been updated with new changes in dev before this merge request
  • I have made corresponding changes to the documentation

Merge request reports