Skip to content

Dynamic filter config finish speedup

Description

Closes issues: Related issues:

  • Use bulk insert to cut Finish submission time to 1/4.
  • Refactor modals to live inside their respective views in the store.
  • Add 'Please wait' and disable button to Finish confirmation modal.

Notes to reviewer

Please double check all modals.

I moved getFilterConfig from addExcludedAlleles into workflow as I think that's where it's supposed to be, but please let me know if it should be moved back.

Type of change

  • New feature
  • Breaking change
  • Bug fix
  • Improvement

Tests

General

  • Tests have been added that prove my fix is effective or that my feature works
  • Related tests have been modified/removed

Hypothesis testing:

  • Soak testing has been done
  • Distribution between positive / negative cases has been checked

Database

  • Includes changes to database schema
  • Includes necessary database migrations

Configuration

  • Includes changes to configuration
  • Includes configuration migration instructions in documentation

General

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My branch has recently been updated with new changes in dev before this merge request
  • I have made corresponding changes to the documentation
Edited by Svein Tore Koksrud Seljebotn

Merge request reports