Skip to content

Changes to cerebral state

Øyvind Evju requested to merge state-cleanup into dev

Description

Closes issues: Related issues:

Restructured views.workflow.

  • Attempt to clean up state under *.data.* to be unmodified from backend
  • Move interpretation related backend data from views.workflows.data to views.workflows.interpretation.data
  • Do not create historyInterpretations in state tree, but leave it as a Compute
  • Remove views.workflow.interpretation.selected, and replace with views.workflow.interpretation.selectedId.
  • Add new action getSelectedInterpretation to fetch interpretation object from views.workflows.data.interpretations, based on value of views.workflow.interpretation.selectedId.
  • Deep copy state and user state from views.workflows.data.interpretations[*] to views.workflows.interpretation.state/userState
  • Replace multiple == with ===

Notes to reviewer

[Are there points in the code the reviewer needs to double check or where you would like advice?]

Type of change

  • New feature
  • Breaking change
  • Bug fix
  • Improvement

General

  • Tests have been added that prove my fix is effective or that my feature works
  • Related tests have been modified/removed

Hypothesis testing:

  • Soak testing has been done
  • Distribution between positive / negative cases has been checked

Database

  • Includes changes to database schema
  • Includes necessary database migrations

Configuration

  • Includes changes to configuration
  • Includes configuration migration instructions in documentation

General

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My branch has recently been updated with new changes in dev before this merge request
  • I have made corresponding changes to the documentation
Edited by Øyvind Evju

Merge request reports

Loading