Remove 2 unreferenced symbols (GraphSurgeon)

Advay Joshirequested to merge
graph-surgeon/dead-code-2x-132e236b into main

GraphSurgeon: removed 2 unreferenced symbols

Each symbol below had zero inbound cross-file references in the GitLab Orbit knowledge graph, was not referenced as code in its own file, and is not allowlisted. The test suite still passes after removal.

Symbol Location Cross-file refs
billing.legacy.normalize_legacy_payload billing/legacy.py:7-12 0
billing.utils.format_amount billing/utils.py:35-41 0

The query, run once per candidate

SELECT count(DISTINCT sym.id)
FROM gl_edge e
JOIN gl_imported_symbol sym ON sym.id = e.source_id OR sym.id = e.target_id
WHERE (e.source_id = :definition_id OR e.target_id = :definition_id)
  AND sym.file_path <> :definition_file;

Zero rows means no other file resolves a reference to the symbol.

Test gate

pytest -q — passed after the deletions.

What GraphSurgeon refused to delete

  • billing.core.process_invoice — 2 cross-file reference(s)
  • billing.utils.apply_discount — used elsewhere in its own file
  • billing.utils.compute_total — 2 cross-file reference(s)
  • tests.test_billing.test_compute_total_sums_line_items — protected by allowlist
  • tests.test_billing.test_compute_total_applies_discount — protected by allowlist
  • tests.test_billing.test_process_invoice_uses_the_aliased_import — protected by allowlist

Graph source: bundled fixture. Point surgeon.toml at a real ~/.orbit/graph.duckdb to run against your codebase.

Generated by GraphSurgeon. Review before merging; this bot never auto-merges.

Merge request reports