Skip to content

Draft: fix: Tab-specific data was removed despite page not having changed [#1234]

Thomas Greiner requested to merge ThomasGreiner-eyeo/abp/ui/adblockplus:ui_1234 into next

This MR contains the following changes:

  • Reverted approach when tab-specific data should be removed.
    Previously (see #1070 (closed)), this was done by calling removeFromAllPageMaps() when the top-level frame gets updated, and when the tab gets removed. Since we're already reacting to when the tab gets removed, it should be sufficient to (a) stop relying ext.pages.onLoading and (b) instead add and listen to a new event that gets dispatched when the top-level frame gets updated.
  • Added description to ext.pages.* events to clarify what they represent and to mention that ext.pages.onLoading can occur more than once.

Merge request reports