Skip to content

WIP: Issue #709 - Independent controller for languages

Andrea Giammarchi requested to merge issue-709 into release-2019-4

The goal of this MR is to decouple languages operations in a way that can be consumed in the new basic settings page and, in a future refactoring, in the Advanced Settings Page too.

The current status is WIP due following points:

  • I would like to have feedback on the current API. As we load things asynchronously it makes perfect sense to me to have an asynchronous API too instead of a synchronous one that cannot be used right away

  • I would like to understand if I am missing important parts of the logic

The latter point is particularly in regards of the additional_subscriptions and subscriptions.get which seems to be non relevant for the languages dropdown component, but I don't have enough background knowledge to understand how that data can be used for filtered languages.

@ThomasGreiner it'd be super helpful if you could have a look and provide some feedback/answer to these questions, thanks a lot in advance.

Edited by Andrea Giammarchi

Merge request reports