Skip to content

feat(cli): ledger sign send tokens [AC-3185]

Sander Postma requested to merge AC-3185_ledger-sign-send-tokens into develop

Closes AC-3185. Implementation of basic Ledger functionality This branch also contains the code for AC-3184 AC-3186 & AC-3187 because they all needed come together to be able to test transaction signing.

NOTE1: The latest fixes in project ledger-go-accumulate is required to build/run this branch. At the time of writing that is "AC-846-golang-ledger-driver-dep-reduce" The branch has been linked using "go get gitlab.com/accumulatenetwork/ledger/ledger-go-accumulate@AC-846-golang-ledger-driver-dep-reduce" When AC-846-golang-ledger-driver-dep-reduce it is recommended to relink the project.

NOTE2: ./scripts/ci/validate-ledger.sh is for manual testing because obviously a CI pipeline doesn't have a Ledger device to its USB port.

Review Checklist

If any item is not complete, the merge request is not ready to be reviewed and must be marked Draft:.

  • The merge request title is in the format <change type>(<change scope>): <short description> [<task id>]
    • For example, feat(cli): add QR code generation [AC-123]
    • For details, see CONTRIBUTING.md
  • The description includes Closes <jira task ID> (or rarely Updates <jira task ID>)
  • The change is fully validated by tests that are run during CI
    • In most cases this means a test in "validate.sh"
    • In some cases, a Go test may be acceptable
    • Validation is not applicable to things like documentation updates
    • Purely UI/UX changes can be manually validated, such as changes to human-readable output
    • For all other changes, automated validation tests are an absolute requirement unless a maintainer specifically explains why they are not in a comment on this merge request
  • The change is marked with one of the validation labels

Merge Checklist

  • CI is passing
  • Merge conflicts are resolved
  • All discussions are resolved

Related to AC-3185

Edited by Sander Postma

Merge request reports