Skip to content

test: fix flaky test [AC-1557]

Ethan Reesor requested to merge AC-1557-fix-TestMissingSynthTxn into develop

Closes AC-1557. Hopefully this will fix the issue where TestMissingSynthTxn fails intermittently in CI. The issue appears to be some kind of interaction between TestRelaunch and TestMissingSynthTxn. I don't know how they would be interacting, and they definitely shouldn't be, but when I run those two together (-run=^(TestRelaunch|TestMissingSynthTxn)$) it often fails, and TestMissingSynthTxn does not fail when run by itself.

I saw error messages like "consensus failure because writing some/file failed" tagged as TestRelaunch, after the test was done. It turns out the test left nodes running without shutting them down. But the tempdir is deleted at the end of the test, so things broke. Still no idea how that would affect TestMissingSynthTxn.

Review Checklist

If any item is not complete, the merge request is not ready to be reviewed and must be marked Draft:.

  • The merge request title is in the format <change type>(<change scope>): <short description> [<task id>]
    • For example, feat(cli): add QR code generation [AC-123]
    • For details, see CONTRIBUTING.md
  • The description includes Closes <jira task ID> (or rarely Updates <jira task ID>)
  • The change is fully validated by tests that are run during CI
    • In most cases this means a test in "validate.sh"
    • In some cases, a Go test may be acceptable
    • Validation is not applicable to things like documentation updates
    • Purely UI/UX changes can be manually validated, such as changes to human-readable output
    • For all other changes, automated validation tests are an absolute requirement unless a maintainer specifically explains why they are not in a comment on this merge request
  • The change is marked with one of the validation labels

Merge Checklist

  • CI is passing
  • Merge conflicts are resolved
  • All discussions are resolved

Related to AC-1557

Edited by Dennis B

Merge request reports