- Jul 22, 2022
-
- Jul 14, 2022
-
-
Ethan Reesor authored
Closes AC-2318. Enable static check directly (since golangci-lint's version is still broken) and fix issues. Partially because it's a good idea, partially because Fairyproof asked. ## Review Checklist **If any item is not complete, the merge request is not ready to be reviewed and must be marked `Draft:`.** - [x] The merge request title is in the format `<change type>(<change scope>): <short description> [<task id>]` - For example, `feat(cli): add QR code generation [AC-123]` - For details, see [CONTRIBUTING.md](/CONTRIBUTING.md) - [x] The description includes `Closes <jira task ID>` (or rarely `Updates <jira task ID>`) - [x] The change is fully validated by tests that are run during CI - In most cases this means a test in "validate.sh" - In some cases, a Go test may be acceptable - Validation is not applicable to things like documentation updates - Purely UI/UX changes can be manually validated, such as changes to human-readable output - For all other changes, automated validation tests are an absolute requirement unless a maintainer specifically explains why they are not in a comment on this merge request - [x] The change is marked with one of the validation labels - ~"validation::ci/cd" for changes validated by CI tests - ~"validation::manual" for changes validated by hand - ~"validation::deferred" for changes validated by a follow up merge request - ~"validation::not applicable" for changes where validation is not applicable ## Merge Checklist - [ ] CI is passing - [ ] Merge conflicts are resolved - [ ] All discussions are resolved Related to AC-2318
-
- Jul 13, 2022
-
-
Dennis B authored
AC-1582 Adds security for seeding via a trusted proxy ## Review Checklist **If any item is not complete, the merge request is not ready to be reviewed and must be marked `Draft:`.** - [ ] The merge request title is in the format `<change type>(<change scope>): <short description> [<task id>]` - For example, `feat(cli): add QR code generation [AC-123]` - For details, see [CONTRIBUTING.md](/CONTRIBUTING.md) - [ ] The description includes `Closes <jira task ID>` (or rarely `Updates <jira task ID>`) - [ ] The change is fully validated by tests that are run during CI - In most cases this means a test in "validate.sh" - In some cases, a Go test may be acceptable - Validation is not applicable to things like documentation updates - Purely UI/UX changes can be manually validated, such as changes to human-readable output - For all other changes, automated validation tests are an absolute requirement unless a maintainer specifically explains why they are not in a comment on this merge request - [ ] The change is marked with one of the validation labels - ~"validation::ci/cd" for changes validated by CI tests - ~"validation::manual" for changes validated by hand - ~"validation::deferred" for changes validated by a follow up merge request - ~"validation::not applicable" for changes where validation is not applicable ## Merge Checklist - [ ] CI is passing - [ ] Merge conflicts are resolved - [ ] All discussions are resolved Related to AC-1582
-
- Jul 12, 2022
-
-
Ethan Reesor authored
Closes AC-2220. Hard-codes the allowed set of chains. Creates a method or method sequence for each chain. Updates (and renames) the resolve-a-chain-by-name method to use a switch statement to enforce the allowed set of chains. This paves the way for AC-2148. ## Review Checklist **If any item is not complete, the merge request is not ready to be reviewed and must be marked `Draft:`.** - [x] The merge request title is in the format `<change type>(<change scope>): <short description> [<task id>]` - For example, `feat(cli): add QR code generation [AC-123]` - For details, see [CONTRIBUTING.md](/CONTRIBUTING.md) - [x] The description includes `Closes <jira task ID>` (or rarely `Updates <jira task ID>`) - [~] The change is fully validated by tests that are run during CI - In most cases this means a test in "validate.sh" - In some cases, a Go test may be acceptable - Validation is not applicable to things like documentation updates - Purely UI/UX changes can be manually validated, such as changes to human-readable output - For all other changes, automated validation tests are an absolute requirement unless a maintainer specifically explains why they are not in a comment on this merge request - [x] The change is marked with one of the validation labels - ~"validation::ci/cd" for changes validated by CI tests - ~"validation::manual" for changes validated by hand - ~"validation::deferred" for changes validated by a follow up merge request - ~"validation::not applicable" for changes where validation is not applicable ## Merge Checklist - [ ] CI is passing - [ ] Merge conflicts are resolved - [ ] All discussions are resolved Related to AC-2220
-
- Jul 05, 2022
-
-
Ethan Reesor authored
Closes AC-1627. Force anchors to be processed in sequence. Write incomplete anchors to the database so they can be queried by other partitions to heal dropped anchors. ## Review Checklist **If any item is not complete, the merge request is not ready to be reviewed and must be marked `Draft:`.** - [x] The merge request title is in the format `<change type>(<change scope>): <short description> [<task id>]` - For example, `feat(cli): add QR code generation [AC-123]` - For details, see [CONTRIBUTING.md](/CONTRIBUTING.md) - [x] The description includes `Closes <jira task ID>` (or rarely `Updates <jira task ID>`) - [x] The change is fully validated by tests that are run during CI - In most cases this means a test in "validate.sh" - In some cases, a Go test may be acceptable - Validation is not applicable to things like documentation updates - Purely UI/UX changes can be manually validated, such as changes to human-readable output - For all other changes, automated validation tests are an absolute requirement unless a maintainer specifically explains why they are not in a comment on this merge request - [x] The change is marked with one of the validation labels - ~"validation::ci/cd" for changes validated by CI tests - ~"validation::manual" for changes validated by hand - ~"validation::deferred" for changes validated by a follow up merge request - ~"validation::not applicable" for changes where validation is not applicable ## Merge Checklist - [ ] CI is passing - [ ] Merge conflicts are resolved - [ ] All discussions are resolved Related to AC-1627
-
- Jul 01, 2022
-
-
Ethan Reesor authored
- Closes AC-1970. - Clarifies the logic for calculating the BPT hash. - Moves account indices to the data model. - Moves account metadata into indices. ## Review Checklist **If any item is not complete, the merge request is not ready to be reviewed and must be marked `Draft:`.** - [x] The merge request title is in the format `<change type>(<change scope>): <short description> [<task id>]` - For example, `feat(cli): add QR code generation [AC-123]` - For details, see [CONTRIBUTING.md](/CONTRIBUTING.md) - [x] The description includes `Closes <jira task ID>` (or rarely `Updates <jira task ID>`) - [~] The change is fully validated by tests that are run during CI - In most cases this means a test in "validate.sh" - In some cases, a Go test may be acceptable - Validation is not applicable to things like documentation updates - Purely UI/UX changes can be manually validated, such as changes to human-readable output - For all other changes, automated validation tests are an absolute requirement unless a maintainer specifically explains why they are not in a comment on this merge request - [x] The change is marked with one of the validation labels - ~"validation::ci/cd" for changes validated by CI tests - ~"validation::manual" for changes validated by hand - ~"validation::deferred" for changes validated by a follow up merge request - ~"validation::not applicable" for changes where validation is not applicable ## Merge Checklist - [ ] CI is passing - [ ] Merge conflicts are resolved - [ ] All discussions are resolved Related to AC-1970
-
Closes AC-1628. *Replace scratch accounts with scratch chains* ## Review Checklist **If any item is not complete, the merge request is not ready to be reviewed and must be marked `Draft:`.** - [x] The merge request title is in the format `<change type>(<change scope>): <short description> [<task id>]` - For example, `feat(cli): add QR code generation [AC-123]` - For details, see [CONTRIBUTING.md](/CONTRIBUTING.md) - [x] The description includes `Closes <jira task ID>` (or rarely `Updates <jira task ID>`) - [x] The change is fully validated by tests that are run during CI - In most cases this means a test in "validate.sh" - In some cases, a Go test may be acceptable - Validation is not applicable to things like documentation updates - Purely UI/UX changes can be manually validated, such as changes to human-readable output - For all other changes, automated validation tests are an absolute requirement unless a maintainer specifically explains why they are not in a comment on this merge request - [x] The change is marked with one of the validation labels - ~"validation::ci/cd" for changes validated by CI tests - ~"validation::manual" for changes validated by hand - ~"validation::deferred" for changes validated by a follow up merge request - ~"validation::not applicable" for changes where validation is not applicable ## Merge Checklist - [ ] CI is passing - [ ] Merge conflicts are resolved - [ ] All discussions are resolved Related to AC-1628
-
- Jun 27, 2022
-
-
Closes AC-1969. Create a data model entity for `internal/database.Account` and create data model attributes for its components. ## Review Checklist **If any item is not complete, the merge request is not ready to be reviewed and must be marked `Draft:`.** - [x] The merge request title is in the format `<change type>(<change scope>): <short description> [<task id>]` - For example, `feat(cli): add QR code generation [AC-123]` - For details, see [CONTRIBUTING.md](/CONTRIBUTING.md) - [x] The description includes `Closes <jira task ID>` (or rarely `Updates <jira task ID>`) - [~] The change is fully validated by tests that are run during CI - In most cases this means a test in "validate.sh" - In some cases, a Go test may be acceptable - Validation is not applicable to things like documentation updates - Purely UI/UX changes can be manually validated, such as changes to human-readable output - For all other changes, automated validation tests are an absolute requirement unless a maintainer specifically explains why they are not in a comment on this merge request - [x] The change is marked with one of the validation labels - ~"validation::ci/cd" for changes validated by CI tests - ~"validation::manual" for changes validated by hand - ~"validation::deferred" for changes validated by a follow up merge request - ~"validation::not applicable" for changes where validation is not applicable ## Merge Checklist - [x] CI is passing - [ ] Merge conflicts are resolved - [x] All discussions are resolved Related to AC-1969
-
- Jun 26, 2022
-
-
Closes AC-1664. The transaction status has too many status fields and we have two separate custom errors and error/status code sets. Simplify the transaction status, error/status codes, and error handling. Consolidate all of the transaction status fields into a status code field and an error field. Remove the old custom error and the old error codes. ## Review Checklist **If any item is not complete, the merge request is not ready to be reviewed and must be marked `Draft:`.** - [x] The merge request title is in the format `<change type>(<change scope>): <short description> [<task id>]` - For example, `feat(cli): add QR code generation [AC-123]` - For details, see [CONTRIBUTING.md](/CONTRIBUTING.md) - [x] The description includes `Closes <jira task ID>` (or rarely `Updates <jira task ID>`) - [~] The change is fully validated by tests that are run during CI - In most cases this means a test in "validate.sh" - In some cases, a Go test may be acceptable - Validation is not applicable to things like documentation updates - Purely UI/UX changes can be manually validated, such as changes to human-readable output - For all other changes, automated validation tests are an absolute requirement unless a maintainer specifically explains why they are not in a comment on this merge request - [x] The change is marked with one of the validation labels - ~"validation::ci/cd" for changes validated by CI tests - ~"validation::manual" for changes validated by hand - ~"validation::deferred" for changes validated by a follow up merge request - ~"validation::not applicable" for changes where validation is not applicable ## Merge Checklist - [x] CI is passing - [ ] Merge conflicts are resolved - [ ] All discussions are resolved Related to AC-1664
-
- Jun 21, 2022
-
-
Closes [AC-1600]. Rename subnet to partition ## Review Checklist **If any item is not complete, the merge request is not ready to be reviewed and must be marked `Draft:`.** - [ ] The merge request title is in the format `<change type>(<change scope>): <short description> [<task id>]` - For example, `feat(cli): add QR code generation [AC-123]` - For details, see [CONTRIBUTING.md](/CONTRIBUTING.md) - [ ] The description includes `Closes <jira task ID>` (or rarely `Updates <jira task ID>`) - [ ] The change is fully validated by tests that are run during CI - In most cases this means a test in "validate.sh" - In some cases, a Go test may be acceptable - Validation is not applicable to things like documentation updates - Purely UI/UX changes can be manually validated, such as changes to human-readable output - For all other changes, automated validation tests are an absolute requirement unless a maintainer specifically explains why they are not in a comment on this merge request - [ ] The change is marked with one of the validation labels - ~"validation::ci/cd" for changes validated by CI tests - ~"validation::manual" for changes validated by hand - ~"validation::deferred" for changes validated by a follow up merge request - ~"validation::not applicable" for changes where validation is not applicable ## Merge Checklist - [ ] CI is passing - [ ] Merge conflicts are resolved - [ ] All discussions are resolved Related to AC-1600
-
- Jun 20, 2022
-
-
Ethan Reesor authored
Closes AC-1695. Implements a caching data model. Adds a generator to generate a caching data model implementation from an abstract data model described in a YAML file. Re-implements the SMT database manager as a partial caching data model. ## Review Checklist **If any item is not complete, the merge request is not ready to be reviewed and must be marked `Draft:`.** - [x] The merge request title is in the format `<change type>(<change scope>): <short description> [<task id>]` - For example, `feat(cli): add QR code generation [AC-123]` - For details, see [CONTRIBUTING.md](/CONTRIBUTING.md) - [x] The description includes `Closes <jira task ID>` (or rarely `Updates <jira task ID>`) - [x] The change is fully validated by tests that are run during CI - In most cases this means a test in "validate.sh" - In some cases, a Go test may be acceptable - Validation is not applicable to things like documentation updates - Purely UI/UX changes can be manually validated, such as changes to human-readable output - For all other changes, automated validation tests are an absolute requirement unless a maintainer specifically explains why they are not in a comment on this merge request - [x] The change is marked with one of the validation labels - ~"validation::ci/cd" for changes validated by CI tests - ~"validation::manual" for changes validated by hand - ~"validation::deferred" for changes validated by a follow up merge request - ~"validation::not applicable" for changes where validation is not applicable ## Merge Checklist - [x] CI is passing - [x] Merge conflicts are resolved - [ ] All discussions are resolved Related to AC-1695
-
Closes AC-1680. Overhauls network initialization code. ## Review Checklist **If any item is not complete, the merge request is not ready to be reviewed and must be marked `Draft:`.** - [ ] The merge request title is in the format `<change type>(<change scope>): <short description> [<task id>]` - For example, `feat(cli): add QR code generation [AC-123]` - For details, see [CONTRIBUTING.md](/CONTRIBUTING.md) - [ ] The description includes `Closes <jira task ID>` (or rarely `Updates <jira task ID>`) - [ ] The change is fully validated by tests that are run during CI - In most cases this means a test in "validate.sh" - In some cases, a Go test may be acceptable - Validation is not applicable to things like documentation updates - Purely UI/UX changes can be manually validated, such as changes to human-readable output - For all other changes, automated validation tests are an absolute requirement unless a maintainer specifically explains why they are not in a comment on this merge request - [ ] The change is marked with one of the validation labels - ~"validation::ci/cd" for changes validated by CI tests - ~"validation::manual" for changes validated by hand - ~"validation::deferred" for changes validated by a follow up merge request - ~"validation::not applicable" for changes where validation is not applicable ## Merge Checklist - [ ] CI is passing - [ ] Merge conflicts are resolved - [ ] All discussions are resolved Related to AC-1680
-
- Jun 15, 2022
-
-
Ethan Reesor authored
- Closes AC-1568 - Removes the validator key books - Simplifies the BVN operator key books (one page w/ remote auth vs two pages w/ delegated auth) - Moves special network account handling logic out of transaction executors into `internal/block/network_accounts.go` - Eliminates validator transactions - Updates Tendermint validator set via global values instead of via special transactions - Updates `dn/network` to store keys instead of key hashes - Updates genesis and node initialization to allow global values to be overridden at genesis ## Review Checklist **If any item is not complete, the merge request is not ready to be reviewed and must be marked `Draft:`.** - [x] The merge request title is in the format `<change type>(<change scope>): <short description> [<task id>]` - For example, `feat(cli): add QR code generation [AC-123]` - For details, see [CONTRIBUTING.md](/CONTRIBUTING.md) - [x] The description includes `Closes <jira task ID>` (or rarely `Updates <jira task ID>`) - [x] The change is fully validated by tests that are run during CI - In most cases this means a test in "validate.sh" - In some cases, a Go test may be acceptable - Validation is not applicable to things like documentation updates - Purely UI/UX changes can be manually validated, such as changes to human-readable output - For all other changes, automated validation tests are an absolute requirement unless a maintainer specifically explains why they are not in a comment on this merge request - [x] The change is marked with one of the validation labels - ~"validation::ci/cd" for changes validated by CI tests - ~"validation::manual" for changes validated by hand - ~"validation::deferred" for changes validated by a follow up merge request - ~"validation::not applicable" for changes where validation is not applicable ## Merge Checklist - [ ] CI is passing - [ ] Merge conflicts are resolved - [ ] All discussions are resolved Related to AC-1568
-
- Jun 13, 2022
-
-
Ethan Reesor authored
Closes AC-1696. Updates typegen for AC-1598. I'm splitting this into its own MR to reduce the size of !403. ## Review Checklist **If any item is not complete, the merge request is not ready to be reviewed and must be marked `Draft:`.** - [x] The merge request title is in the format `<change type>(<change scope>): <short description> [<task id>]` - For example, `feat(cli): add QR code generation [AC-123]` - For details, see [CONTRIBUTING.md](/CONTRIBUTING.md) - [x] The description includes `Closes <jira task ID>` (or rarely `Updates <jira task ID>`) - [x] The change is fully validated by tests that are run during CI - In most cases this means a test in "validate.sh" - In some cases, a Go test may be acceptable - Validation is not applicable to things like documentation updates - Purely UI/UX changes can be manually validated, such as changes to human-readable output - For all other changes, automated validation tests are an absolute requirement unless a maintainer specifically explains why they are not in a comment on this merge request - [x] The change is marked with one of the validation labels - ~"validation::ci/cd" for changes validated by CI tests - ~"validation::manual" for changes validated by hand - ~"validation::deferred" for changes validated by a follow up merge request - ~"validation::not applicable" for changes where validation is not applicable ## Merge Checklist - [ ] CI is passing - [ ] Merge conflicts are resolved - [ ] All discussions are resolved Related to AC-1696
-
Closes AC-1217. *Major block api implementation.* Example CLI command ``` accumulate --use-unencrypted-wallet blocks major bvn-bvn0 1 4 ``` ## Review Checklist **If any item is not complete, the merge request is not ready to be reviewed and must be marked `Draft:`.** - [x] The merge request title is in the format `<change type>(<change scope>): <short description> [<task id>]` - For example, `feat(cli): add QR code generation [AC-123]` - For details, see [CONTRIBUTING.md](/CONTRIBUTING.md) - [x] The description includes `Closes <jira task ID>` (or rarely `Updates <jira task ID>`) - [x] The change is fully validated by tests that are run during CI - In most cases this means a test in "validate.sh" - In some cases, a Go test may be acceptable - Validation is not applicable to things like documentation updates - Purely UI/UX changes can be manually validated, such as changes to human-readable output - For all other changes, automated validation tests are an absolute requirement unless a maintainer specifically explains why they are not in a comment on this merge request - [x] The change is marked with one of the validation labels - ~"validation::ci/cd" for changes validated by CI tests - ~"validation::manual" for changes validated by hand - ~"validation::deferred" for changes validated by a follow up merge request - ~"validation::not applicable" for changes where validation is not applicable ## Merge Checklist - [ ] CI is passing - [ ] Merge conflicts are resolved - [ ] All discussions are resolved Related to AC-1217
-
- Jun 11, 2022
-
-
Dennis B authored
Closes AC-1199 - added API for fetching network configuration/seeds from proxy server - Standardized network configuration to provide consistency on how network config is handled. - Added --seed option to allow for network configuration to be obtained via upcoming proxy nodes for init dual mode - Add p2p peer checking for building bootstrap peers for a single node. ## Review Checklist **If any item is not complete, the merge request is not ready to be reviewed and must be marked `Draft:`.** - [ ] The merge request title is in the format `<change type>(<change scope>): <short description> [<task id>]` - For example, `feat(cli): add QR code generation [AC-123]` - For details, see [CONTRIBUTING.md](/CONTRIBUTING.md) - [ ] The description includes `Closes <jira task ID>` (or rarely `Updates <jira task ID>`) - [ ] The change is fully validated by tests that are run during CI - In most cases, this means a test in "validate.sh" - In some cases, a Go test may be acceptable - Validation is not applicable to things like documentation updates - Purely UI/UX changes can be manually validated, such as changes to human-readable output - For all other changes, automated validation tests are an absolute requirement unless a maintainer specifically explains why they are not in a comment on this merge request - [ ] The change is marked with one of the validation labels - ~"validation::ci/cd" for changes validated by CI tests - ~"validation::manual" for changes validated by hand - ~"validation::deferred" for changes validated by a follow up merge request - ~"validation::not applicable" for changes where validation is not applicable ## Merge Checklist - [ ] CI is passing - [ ] Merge conflicts are resolved - [ ] All discussions are resolved Related to AC-1199
-
- Jun 10, 2022
-
-
Closes AC-1641. Rewrite indexes and merkle trees to use the struct-based cache instead of interacting directly with the key-value store. ## Review Checklist **If any item is not complete, the merge request is not ready to be reviewed and must be marked `Draft:`.** - [x] The merge request title is in the format `<change type>(<change scope>): <short description> [<task id>]` - For example, `feat(cli): add QR code generation [AC-123]` - For details, see [CONTRIBUTING.md](/CONTRIBUTING.md) - [x] The description includes `Closes <jira task ID>` (or rarely `Updates <jira task ID>`) - [x] The change is fully validated by tests that are run during CI - In most cases this means a test in "validate.sh" - In some cases, a Go test may be acceptable - Validation is not applicable to things like documentation updates - Purely UI/UX changes can be manually validated, such as changes to human-readable output - For all other changes, automated validation tests are an absolute requirement unless a maintainer specifically explains why they are not in a comment on this merge request - [x] The change is marked with one of the validation labels - ~"validation::ci/cd" for changes validated by CI tests - ~"validation::manual" for changes validated by hand - ~"validation::deferred" for changes validated by a follow up merge request - ~"validation::not applicable" for changes where validation is not applicable ## Merge Checklist - [ ] CI is passing - [ ] Merge conflicts are resolved - [ ] All discussions are resolved Related to AC-1641
-
- Jun 09, 2022
-
-
Closes AC-1601. Makes routing dynamic. Updates to `dn/routing` are pushed to BVNs and cause the router to update itself. I will add a test. ## Review Checklist **If any item is not complete, the merge request is not ready to be reviewed and must be marked `Draft:`.** - [x] The merge request title is in the format `<change type>(<change scope>): <short description> [<task id>]` - For example, `feat(cli): add QR code generation [AC-123]` - For details, see [CONTRIBUTING.md](/CONTRIBUTING.md) - [x] The description includes `Closes <jira task ID>` (or rarely `Updates <jira task ID>`) - [x] The change is fully validated by tests that are run during CI - In most cases this means a test in "validate.sh" - In some cases, a Go test may be acceptable - Validation is not applicable to things like documentation updates - Purely UI/UX changes can be manually validated, such as changes to human-readable output - For all other changes, automated validation tests are an absolute requirement unless a maintainer specifically explains why they are not in a comment on this merge request - [x] The change is marked with one of the validation labels - ~"validation::ci/cd" for changes validated by CI tests - ~"validation::manual" for changes validated by hand - ~"validation::deferred" for changes validated by a follow up merge request - ~"validation::not applicable" for changes where validation is not applicable ## Merge Checklist - [ ] CI is passing - [ ] Merge conflicts are resolved - [ ] All discussions are resolved Related to AC-1601
-
- Jun 03, 2022
-
-
Ethan Reesor authored
Closes AC-1588. Holds global network values in-memory in a variable. - Creates `internal/core.GlobalValues` type that is responsible for loading and storing network global value accounts. - Changes marshalling for network global value accounts from JSON to binary. - Adds an active and pending global values variable to the executor to track the current, active global values and pending changes. - Adds logic to `internal/block.Executor.ProcessTransaction` to update the pending global values when the relevant account is changed. - Adds additional validation to ensure it is impossible to update a network global value account to an invalid state. - Enforces write-to-state for network global value account. - Removes oracle from the ledger (use global values instead). - Removes oracle from the directory anchor (updated via Updates instead). - Updates executors to use the active global values instead of parsing data entries. - Adds global values to API `describe` method ## Review Checklist **If any item is not complete, the merge request is not ready to be reviewed and must be marked `Draft:`.** - [x] The merge request title is in the format `<change type>(<change scope>): <short description> [<task id>]` - For example, `feat(cli): add QR code generation [AC-123]` - For details, see [CONTRIBUTING.md](/CONTRIBUTING.md) - [x] The description includes `Closes <jira task ID>` (or rarely `Updates <jira task ID>`) - [x] The change is fully validated by tests that are run during CI - In most cases this means a test in "validate.sh" - In some cases, a Go test may be acceptable - Validation is not applicable to things like documentation updates - Purely UI/UX changes can be manually validated, such as changes to human-readable output - For all other changes, automated validation tests are an absolute requirement unless a maintainer specifically explains why they are not in a comment on this merge request - [x] The change is marked with one of the validation labels - ~"validation::ci/cd" for changes validated by CI tests - ~"validation::manual" for changes validated by hand - ~"validation::deferred" for changes validated by a follow up merge request - ~"validation::not applicable" for changes where validation is not applicable ## Merge Checklist - [ ] CI is passing - [ ] Merge conflicts are resolved - [ ] All discussions are resolved Related to AC-1588
-
Ethan Reesor authored
Closes AC-1490. Introduces the idea of the transaction ID as a URL, which are therefore routable. ## Review Checklist **If any item is not complete, the merge request is not ready to be reviewed and must be marked `Draft:`.** - [x] The merge request title is in the format `<change type>(<change scope>): <short description> [<task id>]` - For example, `feat(cli): add QR code generation [AC-123]` - For details, see [CONTRIBUTING.md](/CONTRIBUTING.md) - [x] The description includes `Closes <jira task ID>` (or rarely `Updates <jira task ID>`) - [x] The change is fully validated by tests that are run during CI - In most cases this means a test in "validate.sh" - In some cases, a Go test may be acceptable - Validation is not applicable to things like documentation updates - Purely UI/UX changes can be manually validated, such as changes to human-readable output - For all other changes, automated validation tests are an absolute requirement unless a maintainer specifically explains why they are not in a comment on this merge request - [x] The change is marked with one of the validation labels - ~"validation::ci/cd" for changes validated by CI tests - ~"validation::manual" for changes validated by hand - ~"validation::deferred" for changes validated by a follow up merge request - ~"validation::not applicable" for changes where validation is not applicable ## Merge Checklist - [ ] CI is passing - [ ] Merge conflicts are resolved - [ ] All discussions are resolved Related to AC-1490
-
Ethan Reesor authored
Closes AC-756. Implement a proper routing table. ## Review Checklist **If any item is not complete, the merge request is not ready to be reviewed and must be marked `Draft:`.** - [ ] The merge request title is in the format `<change type>(<change scope>): <short description> [<task id>]` - For example, `feat(cli): add QR code generation [AC-123]` - For details, see [CONTRIBUTING.md](/CONTRIBUTING.md) - [ ] The description includes `Closes <jira task ID>` (or rarely `Updates <jira task ID>`) - [ ] The change is fully validated by tests that are run during CI - In most cases this means a test in "validate.sh" - In some cases, a Go test may be acceptable - Validation is not applicable to things like documentation updates - Purely UI/UX changes can be manually validated, such as changes to human-readable output - For all other changes, automated validation tests are an absolute requirement unless a maintainer specifically explains why they are not in a comment on this merge request - [ ] The change is marked with one of the validation labels - ~"validation::ci/cd" for changes validated by CI tests - ~"validation::manual" for changes validated by hand - ~"validation::deferred" for changes validated by a follow up merge request - ~"validation::not applicable" for changes where validation is not applicable ## Merge Checklist - [ ] CI is passing - [ ] Merge conflicts are resolved - [ ] All discussions are resolved Related to AC-756
-
Ethan Reesor authored
-
- Jun 02, 2022
-
-
Ethan Reesor authored
Closes AC-1489. Force ADIs to have a .acme TLD. ## Review Checklist **If any item is not complete, the merge request is not ready to be reviewed and must be marked `Draft:`.** - [x] The merge request title is in the format `<change type>(<change scope>): <short description> [<task id>]` - For example, `feat(cli): add QR code generation [AC-123]` - For details, see [CONTRIBUTING.md](/CONTRIBUTING.md) - [x] The description includes `Closes <jira task ID>` (or rarely `Updates <jira task ID>`) - [x] The change is fully validated by tests that are run during CI - In most cases this means a test in "validate.sh" - In some cases, a Go test may be acceptable - Validation is not applicable to things like documentation updates - Purely UI/UX changes can be manually validated, such as changes to human-readable output - For all other changes, automated validation tests are an absolute requirement unless a maintainer specifically explains why they are not in a comment on this merge request - [x] The change is marked with one of the validation labels - ~"validation::ci/cd" for changes validated by CI tests - ~"validation::manual" for changes validated by hand - ~"validation::deferred" for changes validated by a follow up merge request - ~"validation::not applicable" for changes where validation is not applicable ## Merge Checklist - [ ] CI is passing - [ ] Merge conflicts are resolved - [ ] All discussions are resolved Related to AC-1489
-
Ethan Reesor authored
Closes AC-1580. Allow a data entry to be stored in the account state. When writing to a non-scratch ADI data account, if the transaction specifies `writeToState: true`, write the entry to the account state as well as the main chain. This MR modifies how hashes are calculated for WriteData, WriteDataTo, and SyntheticWriteData transactions to improve robustness. ## Review Checklist **If any item is not complete, the merge request is not ready to be reviewed and must be marked `Draft:`.** - [x] The merge request title is in the format `<change type>(<change scope>): <short description> [<task id>]` - For example, `feat(cli): add QR code generation [AC-123]` - For details, see [CONTRIBUTING.md](/CONTRIBUTING.md) - [x] The description includes `Closes <jira task ID>` (or rarely `Updates <jira task ID>`) - [x] The change is fully validated by tests that are run during CI - In most cases this means a test in "validate.sh" - In some cases, a Go test may be acceptable - Validation is not applicable to things like documentation updates - Purely UI/UX changes can be manually validated, such as changes to human-readable output - For all other changes, automated validation tests are an absolute requirement unless a maintainer specifically explains why they are not in a comment on this merge request - [x] The change is marked with one of the validation labels - ~"validation::ci/cd" for changes validated by CI tests - ~"validation::manual" for changes validated by hand - ~"validation::deferred" for changes validated by a follow up merge request - ~"validation::not applicable" for changes where validation is not applicable ## Merge Checklist - [ ] CI is passing - [ ] Merge conflicts are resolved - [ ] All discussions are resolved Related to AC-1580
-
Ethan Reesor authored
Closes AC-1484. Verify that the key used to sign a synthetic transaction actually belongs to an operator. ## Review Checklist **If any item is not complete, the merge request is not ready to be reviewed and must be marked `Draft:`.** - [x] The merge request title is in the format `<change type>(<change scope>): <short description> [<task id>]` - For example, `feat(cli): add QR code generation [AC-123]` - For details, see [CONTRIBUTING.md](/CONTRIBUTING.md) - [x] The description includes `Closes <jira task ID>` (or rarely `Updates <jira task ID>`) - [x] The change is fully validated by tests that are run during CI - In most cases this means a test in "validate.sh" - In some cases, a Go test may be acceptable - Validation is not applicable to things like documentation updates - Purely UI/UX changes can be manually validated, such as changes to human-readable output - For all other changes, automated validation tests are an absolute requirement unless a maintainer specifically explains why they are not in a comment on this merge request - [x] The change is marked with one of the validation labels - ~"validation::ci/cd" for changes validated by CI tests - ~"validation::manual" for changes validated by hand - ~"validation::deferred" for changes validated by a follow up merge request - ~"validation::not applicable" for changes where validation is not applicable ## Merge Checklist - [ ] CI is passing - [ ] Merge conflicts are resolved - [ ] All discussions are resolved Related to AC-1484
-
- May 25, 2022
-
-
Closes AC-1398. *Dn account subnets* ## Review Checklist **If any item is not complete, the merge request is not ready to be reviewed and must be marked `Draft:`.** - [x] The merge request title is in the format `<change type>(<change scope>): <short description> [<task id>]` - For example, `feat(cli): add QR code generation [AC-123]` - For details, see [CONTRIBUTING.md](/CONTRIBUTING.md) - [x] The description includes `Closes <jira task ID>` (or rarely `Updates <jira task ID>`) - [x] The change is fully validated by tests that are run during CI - In most cases this means a test in "validate.sh" - In some cases, a Go test may be acceptable - Validation is not applicable to things like documentation updates - Purely UI/UX changes can be manually validated, such as changes to human-readable output - For all other changes, automated validation tests are an absolute requirement unless a maintainer specifically explains why they are not in a comment on this merge request - [x] The change is marked with one of the validation labels - ~"validation::ci/cd" for changes validated by CI tests - ~"validation::manual" for changes validated by hand - ~"validation::deferred" for changes validated by a follow up merge request - ~"validation::not applicable" for changes where validation is not applicable ## Merge Checklist - [ ] CI is passing - [ ] Merge conflicts are resolved - [ ] All discussions are resolved Related to AC-1398
-
- May 20, 2022
-
-
Ethan Reesor authored
Closes AC-1522. Rename the `owner` field of a key page entry to `delegate`. ## Review Checklist **If any item is not complete, the merge request is not ready to be reviewed and must be marked `Draft:`.** - [x] The merge request title is in the format `<change type>(<change scope>): <short description> [<task id>]` - For example, `feat(cli): add QR code generation [AC-123]` - For details, see [CONTRIBUTING.md](/CONTRIBUTING.md) - [x] The description includes `Closes <jira task ID>` (or rarely `Updates <jira task ID>`) - [x] The change is fully validated by tests that are run during CI - In most cases this means a test in "validate.sh" - In some cases, a Go test may be acceptable - Validation is not applicable to things like documentation updates - Purely UI/UX changes can be manually validated, such as changes to human-readable output - For all other changes, automated validation tests are an absolute requirement unless a maintainer specifically explains why they are not in a comment on this merge request - [x] The change is marked with one of the validation labels - ~"validation::ci/cd" for changes validated by CI tests - ~"validation::manual" for changes validated by hand - ~"validation::deferred" for changes validated by a follow up merge request - ~"validation::not applicable" for changes where validation is not applicable ## Merge Checklist - [ ] CI is passing - [ ] Merge conflicts are resolved - [ ] All discussions are resolved Related to AC-1522
-
Ethan Reesor authored
Closes AC-816. Guarantee delivery of synthetic transactions. ## Review Checklist **If any item is not complete, the merge request is not ready to be reviewed and must be marked `Draft:`.** - [x] The merge request title is in the format `<change type>(<change scope>): <short description> [<task id>]` - For example, `feat(cli): add QR code generation [AC-123]` - For details, see [CONTRIBUTING.md](/CONTRIBUTING.md) - [x] The description includes `Closes <jira task ID>` (or rarely `Updates <jira task ID>`) - [x] The change is fully validated by tests that are run during CI - In most cases this means a test in "validate.sh" - In some cases, a Go test may be acceptable - Validation is not applicable to things like documentation updates - Purely UI/UX changes can be manually validated, such as changes to human-readable output - For all other changes, automated validation tests are an absolute requirement unless a maintainer specifically explains why they are not in a comment on this merge request - [x] The change is marked with one of the validation labels - ~"validation::ci/cd" for changes validated by CI tests - ~"validation::manual" for changes validated by hand - ~"validation::deferred" for changes validated by a follow up merge request - ~"validation::not applicable" for changes where validation is not applicable ## Merge Checklist - [ ] CI is passing - [ ] Merge conflicts are resolved - [ ] All discussions are resolved Related to AC-816
-
- May 19, 2022
-
-
Ethan Reesor authored
Closes AC-1530. Convert `types/api/query` request types into a tagged union, like transaction bodies or signatures. ## Review Checklist **If any item is not complete, the merge request is not ready to be reviewed and must be marked `Draft:`.** - [x] The merge request title is in the format `<change type>(<change scope>): <short description> [<task id>]` - For example, `feat(cli): add QR code generation [AC-123]` - For details, see [CONTRIBUTING.md](/CONTRIBUTING.md) - [x] The description includes `Closes <jira task ID>` (or rarely `Updates <jira task ID>`) - [x] The change is fully validated by tests that are run during CI - In most cases this means a test in "validate.sh" - In some cases, a Go test may be acceptable - Validation is not applicable to things like documentation updates - Purely UI/UX changes can be manually validated, such as changes to human-readable output - For all other changes, automated validation tests are an absolute requirement unless a maintainer specifically explains why they are not in a comment on this merge request - [x] The change is marked with one of the validation labels - ~"validation::ci/cd" for changes validated by CI tests - ~"validation::manual" for changes validated by hand - ~"validation::deferred" for changes validated by a follow up merge request - ~"validation::not applicable" for changes where validation is not applicable ## Merge Checklist - [ ] CI is passing - [ ] Merge conflicts are resolved - [ ] All discussions are resolved Related to AC-1530
-
- May 17, 2022
-
-
Closes AC-1461. *Query minor blocks total bugfix.* ## Review Checklist **If any item is not complete, the merge request is not ready to be reviewed and must be marked `Draft:`.** - [x] The merge request title is in the format `<change type>(<change scope>): <short description> [<task id>]` - For example, `feat(cli): add QR code generation [AC-123]` - For details, see [CONTRIBUTING.md](/CONTRIBUTING.md) - [x] The description includes `Closes <jira task ID>` (or rarely `Updates <jira task ID>`) - [x] The change is fully validated by tests that are run during CI - In most cases this means a test in "validate.sh" - In some cases, a Go test may be acceptable - Validation is not applicable to things like documentation updates - Purely UI/UX changes can be manually validated, such as changes to human-readable output - For all other changes, automated validation tests are an absolute requirement unless a maintainer specifically explains why they are not in a comment on this merge request - [x] The change is marked with one of the validation labels - ~"validation::ci/cd" for changes validated by CI tests - ~"validation::manual" for changes validated by hand - ~"validation::deferred" for changes validated by a follow up merge request - ~"validation::not applicable" for changes where validation is not applicable ## Merge Checklist - [ ] CI is passing - [ ] Merge conflicts are resolved - [ ] All discussions are resolved Related to AC-1461
-
- May 13, 2022
-
-
Closes AC-1372. term name change ## Review Checklist **If any item is not complete, the merge request is not ready to be reviewed and must be marked `Draft:`.** - [x] The merge request title is in the format `<change type>(<change scope>): <short description> [<task id>]` - For example, `feat(cli): add QR code generation [AC-123]` - For details, see [CONTRIBUTING.md](/CONTRIBUTING.md) - [x] The description includes `Closes <jira task ID>` (or rarely `Updates <jira task ID>`) - [x] The change is fully validated by tests that are run during CI - In most cases this means a test in "validate.sh" - In some cases, a Go test may be acceptable - Validation is not applicable to things like documentation updates - Purely UI/UX changes can be manually validated, such as changes to human-readable output - For all other changes, automated validation tests are an absolute requirement unless a maintainer specifically explains why they are not in a comment on this merge request - [x] The change is marked with one of the validation labels - ~"validation::ci/cd" for changes validated by CI tests - ~"validation::manual" for changes validated by hand - ~"validation::deferred" for changes validated by a follow up merge request - ~"validation::not applicable" for changes where validation is not applicable ## Merge Checklist - [ ] CI is passing - [ ] Merge conflicts are resolved - [ ] All discussions are resolved Related to AC-1372
-
Dennis B authored
Closes AC-1463. - replaced internal transactions/signatures with system transactions/signatures - renamed SyntheticMirror to MirrorSystemRecords and make it a system transaction - split SyntheticAnchor into PartitionAnchor and DirectoryAnchor - Pulled new transactions out of synthetic_transactions.yml to system_transactions.yml system transactions ## Review Checklist **If any item is not complete, the merge request is not ready to be reviewed and must be marked `Draft:`.** - [x] The merge request title is in the format `<change type>(<change scope>): <short description> [<task id>]` - For example, `feat(cli): add QR code generation [AC-123]` - For details, see [CONTRIBUTING.md](/CONTRIBUTING.md) - [x] The description includes `Closes <jira task ID>` (or rarely `Updates <jira task ID>`) - [x] The change is fully validated by tests that are run during CI - In most cases this means a test in "validate.sh" - In some cases, a Go test may be acceptable - Validation is not applicable to things like documentation updates - Purely UI/UX changes can be manually validated, such as changes to human-readable output - For all other changes, automated validation tests are an absolute requirement unless a maintainer specifically explains why they are not in a comment on this merge request - [x] The change is marked with one of the validation labels - ~"validation::ci/cd" for changes validated by CI tests - ~"validation::manual" for changes validated by hand - ~"validation::deferred" for changes validated by a follow up merge request - ~"validation::not applicable" for changes where validation is not applicable ## Merge Checklist - [ ] CI is passing - [x] Merge conflicts are resolved - [ ] All discussions are resolved Related to AC-1463
-
- May 12, 2022
-
-
Closes AC-1504. Convert `DataEntry` into a tagged union type with two concrete implementations, one for Accumulate and one for Factom. ## Review Checklist **If any item is not complete, the merge request is not ready to be reviewed and must be marked `Draft:`.** - [x] The merge request title is in the format `<change type>(<change scope>): <short description> [<task id>]` - For example, `feat(cli): add QR code generation [AC-123]` - For details, see [CONTRIBUTING.md](/CONTRIBUTING.md) - [x] The description includes `Closes <jira task ID>` (or rarely `Updates <jira task ID>`) - [x] The change is fully validated by tests that are run during CI - In most cases this means a test in "validate.sh" - In some cases, a Go test may be acceptable - Validation is not applicable to things like documentation updates - Purely UI/UX changes can be manually validated, such as changes to human-readable output - For all other changes, automated validation tests are an absolute requirement unless a maintainer specifically explains why they are not in a comment on this merge request - [x] The change is marked with one of the validation labels - ~"validation::ci/cd" for changes validated by CI tests - ~"validation::manual" for changes validated by hand - ~"validation::deferred" for changes validated by a follow up merge request - ~"validation::not applicable" for changes where validation is not applicable ## Merge Checklist - [x] CI is passing - [x] Merge conflicts are resolved - [x] All discussions are resolved Related to AC-1504
-
Ethan Reesor authored
Closes AC-1517. Add two custom analyzers: - 'noprint' catches print statements. We should be using the logger for basically everything, and adding print statements is common for debugging. Debugging print statements should not be merged. - 'rangevarref' catches cases where the body of a for-loop captures a reference to a value-type range variable. The analyzer doesn't know how to determine if a value escapes the stack, so it plays it safe by assuming all values escape. This leads to false positives, but dealing with false positives is much better than having bugs because of false negatives. ## Review Checklist **If any item is not complete, the merge request is not ready to be reviewed and must be marked `Draft:`.** - [x] The merge request title is in the format `<change type>(<change scope>): <short description> [<task id>]` - For example, `feat(cli): add QR code generation [AC-123]` - For details, see [CONTRIBUTING.md](/CONTRIBUTING.md) - [x] The description includes `Closes <jira task ID>` (or rarely `Updates <jira task ID>`) - [x] The change is fully validated by tests that are run during CI - In most cases this means a test in "validate.sh" - In some cases, a Go test may be acceptable - Validation is not applicable to things like documentation updates - Purely UI/UX changes can be manually validated, such as changes to human-readable output - For all other changes, automated validation tests are an absolute requirement unless a maintainer specifically explains why they are not in a comment on this merge request - [x] The change is marked with one of the validation labels - ~"validation::ci/cd" for changes validated by CI tests - ~"validation::manual" for changes validated by hand - ~"validation::deferred" for changes validated by a follow up merge request - ~"validation::not applicable" for changes where validation is not applicable ## Merge Checklist - [x] CI is passing - [x] Merge conflicts are resolved - [x] All discussions are resolved Related to AC-1517
-
Ethan Reesor authored
Closes AC-1257. Implements ABCI snapshot functions. **This does not actually implement Tendermint snapshot-based state sync.** There is more work to be done, but I am going to do that in a separate MR. ## Review Checklist **If any item is not complete, the merge request is not ready to be reviewed and must be marked `Draft:`.** - [x] The merge request title is in the format `<change type>(<change scope>): <short description> [<task id>]` - For example, `feat(cli): add QR code generation [AC-123]` - For details, see [CONTRIBUTING.md](/CONTRIBUTING.md) - [x] The description includes `Closes <jira task ID>` (or rarely `Updates <jira task ID>`) - [ ] The change is fully validated by tests that are run during CI - In most cases this means a test in "validate.sh" - In some cases, a Go test may be acceptable - Validation is not applicable to things like documentation updates - Purely UI/UX changes can be manually validated, such as changes to human-readable output - For all other changes, automated validation tests are an absolute requirement unless a maintainer specifically explains why they are not in a comment on this merge request - [x] The change is marked with one of the validation labels - ~"validation::ci/cd" for changes validated by CI tests - ~"validation::manual" for changes validated by hand - ~"validation::deferred" for changes validated by a follow up merge request - ~"validation::not applicable" for changes where validation is not applicable ## Merge Checklist - [ ] CI is passing - [ ] Merge conflicts are resolved - [ ] All discussions are resolved Related to AC-1257
-
- May 11, 2022
-
-
Ethan Reesor authored
Closes AC-1407. Refactor signature processing. Remote signatures will not be forwarded until the remote signer is satisfied. ## Review Checklist **If any item is not complete, the merge request is not ready to be reviewed and must be marked `Draft:`.** - [ ] The merge request title is in the format `<change type>(<change scope>): <short description> [<task id>]` - For example, `feat(cli): add QR code generation [AC-123]` - For details, see [CONTRIBUTING.md](/CONTRIBUTING.md) - [ ] The description includes `Closes <jira task ID>` (or rarely `Updates <jira task ID>`) - [ ] The change is fully validated by tests that are run during CI - In most cases this means a test in "validate.sh" - In some cases, a Go test may be acceptable - Validation is not applicable to things like documentation updates - Purely UI/UX changes can be manually validated, such as changes to human-readable output - For all other changes, automated validation tests are an absolute requirement unless a maintainer specifically explains why they are not in a comment on this merge request - [ ] The change is marked with one of the validation labels - ~"validation::ci/cd" for changes validated by CI tests - ~"validation::manual" for changes validated by hand - ~"validation::deferred" for changes validated by a follow up merge request - ~"validation::not applicable" for changes where validation is not applicable ## Merge Checklist - [ ] CI is passing - [ ] Merge conflicts are resolved - [ ] All discussions are resolved Related to AC-1407
-
- May 09, 2022
-
-
Closes AC-1491. Replace `Manager *url.URL` and `KeyBook *url.URL` with `Authorities []*url.URL` (more or less) in Create transactions. This will allow accounts to be created with any number of managers instead of just one. ## Review Checklist **If any item is not complete, the merge request is not ready to be reviewed and must be marked `Draft:`.** - [x] The merge request title is in the format `<change type>(<change scope>): <short description> [<task id>]` - For example, `feat(cli): add QR code generation [AC-123]` - For details, see [CONTRIBUTING.md](/CONTRIBUTING.md) - [x] The description includes `Closes <jira task ID>` (or rarely `Updates <jira task ID>`) - [x] The change is fully validated by tests that are run during CI - In most cases this means a test in "validate.sh" - In some cases, a Go test may be acceptable - Validation is not applicable to things like documentation updates - Purely UI/UX changes can be manually validated, such as changes to human-readable output - For all other changes, automated validation tests are an absolute requirement unless a maintainer specifically explains why they are not in a comment on this merge request - [x] The change is marked with one of the validation labels - ~"validation::ci/cd" for changes validated by CI tests - ~"validation::manual" for changes validated by hand - ~"validation::deferred" for changes validated by a follow up merge request - ~"validation::not applicable" for changes where validation is not applicable ## Merge Checklist - [ ] CI is passing - [ ] Merge conflicts are resolved - [ ] All discussions are resolved Related to AC-1491
-
- May 06, 2022
-
-
Closes AC-1181. adding factom addresses and balance in genesis ## Review Checklist **If any item is not complete, the merge request is not ready to be reviewed and must be marked `Draft:`.** - [x] The merge request title is in the format `<change type>(<change scope>): <short description> [<task id>]` - For example, `feat(cli): add QR code generation [AC-123]` - For details, see [CONTRIBUTING.md](/CONTRIBUTING.md) - [x] The description includes `Closes <jira task ID>` (or rarely `Updates <jira task ID>`) - [x] The change is fully validated by tests that are run during CI - In most cases this means a test in "validate.sh" - In some cases, a Go test may be acceptable - Validation is not applicable to things like documentation updates - Purely UI/UX changes can be manually validated, such as changes to human-readable output - For all other changes, automated validation tests are an absolute requirement unless a maintainer specifically explains why they are not in a comment on this merge request - [x] The change is marked with one of the validation labels - ~"validation::ci/cd" for changes validated by CI tests - ~"validation::manual" for changes validated by hand - ~"validation::deferred" for changes validated by a follow up merge request - ~"validation::not applicable" for changes where validation is not applicable ## Merge Checklist - [x] CI is passing - [ ] Merge conflicts are resolved - [x] All discussions are resolved Related to AC-1181
-
- May 05, 2022
-
-
Ethan Reesor authored
Closes AC-1349. Add methods to save and restore snapshots of the network state. ## Review Checklist **If any item is not complete, the merge request is not ready to be reviewed and must be marked `Draft:`.** - [x] The merge request title is in the format `<change type>(<change scope>): <short description> [<task id>]` - For example, `feat(cli): add QR code generation [AC-123]` - For details, see [CONTRIBUTING.md](/CONTRIBUTING.md) - [x] The description includes `Closes <jira task ID>` (or rarely `Updates <jira task ID>`) - [x] The change is fully validated by tests that are run during CI - In most cases this means a test in "validate.sh" - In some cases, a Go test may be acceptable - Validation is not applicable to things like documentation updates - Purely UI/UX changes can be manually validated, such as changes to human-readable output - For all other changes, automated validation tests are an absolute requirement unless a maintainer specifically explains why they are not in a comment on this merge request - [x] The change is marked with one of the validation labels - ~"validation::ci/cd" for changes validated by CI tests - ~"validation::manual" for changes validated by hand - ~"validation::deferred" for changes validated by a follow up merge request - ~"validation::not applicable" for changes where validation is not applicable ## Merge Checklist - [ ] CI is passing - [ ] Merge conflicts are resolved - [ ] All discussions are resolved Related to AC-1349
-
- May 03, 2022
-
-
Ethan Reesor authored
Closes AC-1464. Add an API method that accepts and submits an entire envelope, as an alternative to the API methods that build an envelope. ## Review Checklist **If any item is not complete, the merge request is not ready to be reviewed and must be marked `Draft:`.** - [x] The merge request title is in the format `<change type>(<change scope>): <short description> [<task id>]` - For example, `feat(cli): add QR code generation [AC-123]` - For details, see [CONTRIBUTING.md](/CONTRIBUTING.md) - [x] The description includes `Closes <jira task ID>` (or rarely `Updates <jira task ID>`) - [x] The change is fully validated by tests that are run during CI - In most cases this means a test in "validate.sh" - In some cases, a Go test may be acceptable - Validation is not applicable to things like documentation updates - Purely UI/UX changes can be manually validated, such as changes to human-readable output - For all other changes, automated validation tests are an absolute requirement unless a maintainer specifically explains why they are not in a comment on this merge request - [ ] The change is marked with one of the validation labels - ~"validation::ci/cd" for changes validated by CI tests - ~"validation::manual" for changes validated by hand - ~"validation::deferred" for changes validated by a follow up merge request - ~"validation::not applicable" for changes where validation is not applicable ## Merge Checklist - [x] CI is passing - [x] Merge conflicts are resolved - [ ] All discussions are resolved Related to AC-1464
-