Skip to content
Snippets Groups Projects
  • Dennis B's avatar
    5143376b
    chore(prot): standardize network configuration for bootstrapping peers [AC-1199] · 5143376b
    Dennis B authored
    Closes AC-1199
    - added API for fetching network configuration/seeds from proxy server
    - Standardized network configuration to provide consistency on how network config is handled.
    - Added --seed option to allow for network configuration to be obtained via upcoming proxy nodes for init dual mode
    - Add p2p peer checking for building bootstrap peers for a single node.
    
    ## Review Checklist
    
    **If any item is not complete, the merge request is not ready to be reviewed and must be marked `Draft:`.**
    
    - [ ] The merge request title is in the format `<change type>(<change scope>): <short description> [<task id>]`
      - For example, `feat(cli): add QR code generation [AC-123]`
      - For details, see [CONTRIBUTING.md](/CONTRIBUTING.md)
    - [ ] The description includes `Closes <jira task ID>` (or rarely `Updates <jira task ID>`)
    - [ ] The change is fully validated by tests that are run during CI
      - In most cases, this means a test in "validate.sh"
      - In some cases, a Go test may be acceptable
      - Validation is not applicable to things like documentation updates
      - Purely UI/UX changes can be manually validated, such as changes to human-readable output
      - For all other changes, automated validation tests are an absolute requirement unless a maintainer specifically explains why they are not in a comment on this merge request
    - [ ] The change is marked with one of the validation labels
      - ~"validation::ci/cd" for changes validated by CI tests
      - ~"validation::manual" for changes validated by hand
      - ~"validation::deferred" for changes validated by a follow up merge request
      - ~"validation::not applicable" for changes where validation is not applicable
    
    ## Merge Checklist
    
    - [ ] CI is passing
    - [ ] Merge conflicts are resolved
    - [ ] All discussions are resolved
    
    Related to AC-1199
    5143376b
    History
    chore(prot): standardize network configuration for bootstrapping peers [AC-1199]
    Dennis B authored
    Closes AC-1199
    - added API for fetching network configuration/seeds from proxy server
    - Standardized network configuration to provide consistency on how network config is handled.
    - Added --seed option to allow for network configuration to be obtained via upcoming proxy nodes for init dual mode
    - Add p2p peer checking for building bootstrap peers for a single node.
    
    ## Review Checklist
    
    **If any item is not complete, the merge request is not ready to be reviewed and must be marked `Draft:`.**
    
    - [ ] The merge request title is in the format `<change type>(<change scope>): <short description> [<task id>]`
      - For example, `feat(cli): add QR code generation [AC-123]`
      - For details, see [CONTRIBUTING.md](/CONTRIBUTING.md)
    - [ ] The description includes `Closes <jira task ID>` (or rarely `Updates <jira task ID>`)
    - [ ] The change is fully validated by tests that are run during CI
      - In most cases, this means a test in "validate.sh"
      - In some cases, a Go test may be acceptable
      - Validation is not applicable to things like documentation updates
      - Purely UI/UX changes can be manually validated, such as changes to human-readable output
      - For all other changes, automated validation tests are an absolute requirement unless a maintainer specifically explains why they are not in a comment on this merge request
    - [ ] The change is marked with one of the validation labels
      - ~"validation::ci/cd" for changes validated by CI tests
      - ~"validation::manual" for changes validated by hand
      - ~"validation::deferred" for changes validated by a follow up merge request
      - ~"validation::not applicable" for changes where validation is not applicable
    
    ## Merge Checklist
    
    - [ ] CI is passing
    - [ ] Merge conflicts are resolved
    - [ ] All discussions are resolved
    
    Related to AC-1199
Code owners
Assign users and groups as approvers for specific file changes. Learn more.